📌 Pin typing-extensions in tests for compatiblity with Python 3.8, di… · alejsdev/sqlmodel@1b275bd · GitHub

1. alejsdev
2. sqlmodel

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 1b275bd

Browse filesBrowse the repository at this point in the historyBrowse files

tiangolo

authored

📌 Pin typing-extensions in tests for compatiblity with Python 3.8, dirty-equals, Pydantic (fastapi#965)

1 parent 866d9ec commit 1b275bd
Copy full SHA for 1b275bd

2 files changed

+5-2Lines changed: 5 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • test.yml
• requirements-tests.txt

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/test.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/test.yml

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -51,7 +51,7 @@ jobs:
51	51	id: cache
52	52	with:
53	53	path: ${{ env.pythonLocation }}
54		- key: ${{ runner.os }}-python-${{ env.pythonLocation }}-${{ hashFiles('pyproject.toml', 'requirements-tests.txt') }}
	54	+ key: ${{ runner.os }}-python-${{ env.pythonLocation }}-${{ hashFiles('pyproject.toml', 'requirements-tests.txt') }}-v01
55	55	- name: Install Dependencies
56	56	if: steps.cache.outputs.cache-hit != 'true'
57	57	run: pip install -r requirements-tests.txt
@@ -60,7 +60,7 @@ jobs:
60	60	run: pip install --upgrade "pydantic>=1.10.0,<2.0.0"
61	61	- name: Install Pydantic v2
62	62	if: matrix.pydantic-version == 'pydantic-v2'
63		- run: pip install --upgrade "pydantic>=2.0.2,<3.0.0"
	63	+ run: pip install --upgrade "pydantic>=2.0.2,<3.0.0" "typing-extensions==4.6.1"
64	64	- name: Lint
65	65	# Do not run on Python 3.7 as mypy behaves differently
66	66	if: matrix.python-version != '3.7' && matrix.pydantic-version == 'pydantic-v2'

Collapse file

‎requirements-tests.txt‎

Copy file name to clipboardExpand all lines: requirements-tests.txt

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -10,3 +10,6 @@ httpx ==0.24.1
10	10	# TODO: upgrade when deprecating Python 3.7
11	11	dirty-equals ==0.6.0
12	12	jinja2 ==3.1.3
	13	+ # Pin typing-extensions until Python 3.8 is deprecated or the issue with dirty-equals
	14	+ # is fixed, maybe fixed after dropping Python 3.7 and upgrading dirty-equals
	15	+ typing-extensions ==4.6.1

0 commit comments

Comments

0 (0)