🔇 Do not raise deprecation warnings for execute as it's automatically… · alejsdev/sqlmodel@4ac8714 · GitHub

1. alejsdev
2. sqlmodel

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 4ac8714

Browse filesBrowse the repository at this point in the historyBrowse files

tiangolo

authored

🔇 Do not raise deprecation warnings for execute as it's automatically used internally (fastapi#716)

* 🔇 Do not raise deprecation warnings for execute as it's automatically used internally * ✅ Tweak tests to not use deprecated query

1 parent 2ecc862 commit 4ac8714
Copy full SHA for 4ac8714

2 files changed

+5-4Lines changed: 5 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• sqlmodel/orm
  • session.py
• tests
  • test_main.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎sqlmodel/orm/session.py‎

Copy file name to clipboardExpand all lines: sqlmodel/orm/session.py

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -95,7 +95,8 @@ def exec(
95	95	```Python
96	96	heroes = session.exec(select(Hero)).all()
97	97	```
98		- """
	98	+ """,
	99	+ category=None,
99	100	)
100	101	def execute( # type: ignore
101	102	self,

Collapse file

‎tests/test_main.py‎

Copy file name to clipboardExpand all lines: tests/test_main.py

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -3,7 +3,7 @@
3	3	import pytest
4	4	from sqlalchemy.exc import IntegrityError
5	5	from sqlalchemy.orm import RelationshipProperty
6		- from sqlmodel import Field, Relationship, Session, SQLModel, create_engine
	6	+ from sqlmodel import Field, Relationship, Session, SQLModel, create_engine, select
7	7
8	8
9	9	def test_should_allow_duplicate_row_if_unique_constraint_is_not_passed(clear_sqlmodel):
@@ -31,7 +31,7 @@ class Hero(SQLModel, table=True):
31	31	session.refresh(hero_2)
32	32
33	33	with Session(engine) as session:
34		- heroes = session.query(Hero).all()
	34	+ heroes = session.exec(select(Hero)).all()
35	35	assert len(heroes) == 2
36	36	assert heroes[0].name == heroes[1].name
37	37
@@ -61,7 +61,7 @@ class Hero(SQLModel, table=True):
61	61	session.refresh(hero_2)
62	62
63	63	with Session(engine) as session:
64		- heroes = session.query(Hero).all()
	64	+ heroes = session.exec(select(Hero)).all()
65	65	assert len(heroes) == 2
66	66	assert heroes[0].name == heroes[1].name
67	67

0 commit comments

Comments

0 (0)