Commit bf7af69
committed
Upgrade flake8 in pre-commit and fix new warnings
Upgrading flake8 from 6.0.0 to 6.1.0 causes its pycodestyle
dependency to be upgraded from 2.10.* to 2.11.*, which is desirable
because:
- Spurious "E231 missing whitespace after ':'" warnings on 3.12 due
to the lack of full compatibility with Python 3.12 are gone.
- New warnings appear, at least one of which, "E721 do not compare
types, for exact checks use `is` / `is not`, for instance checks
use `isinstance()`", does identify something we can improve.
This upgrades flake8 in pre-commit and fixes the new warnings.1 parent a5a6464 commit bf7af69
4 files changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,6 +1,6 @@ | |||
| 1 | 1 | repos: | |
| 2 | 2 | - repo: https://github.com/PyCQA/flake8 | |
| 3 | - rev: 6.0.0 | ||
| 3 | + rev: 6.1.0 | ||
| 4 | 4 | hooks: | |
| 5 | 5 | - id: flake8 | |
| 6 | 6 | additional_dependencies: | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1403,7 +1403,7 @@ def iter_items( | |||
| 1403 | 1403 | # END handle critical error | |
| 1404 | 1404 | ||
| 1405 | 1405 | # Make sure we are looking at a submodule object | |
| 1406 | - if type(sm) != git.objects.submodule.base.Submodule: | ||
| 1406 | + if type(sm) is not git.objects.submodule.base.Submodule: | ||
| 1407 | 1407 | continue | |
| 1408 | 1408 | ||
| 1409 | 1409 | # fill in remaining info - saves time as it doesn't have to be parsed again | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -244,7 +244,7 @@ def entry_at(cls, filepath: PathLike, index: int) -> "RefLogEntry": | |||
| 244 | 244 | for i in range(index + 1): | |
| 245 | 245 | line = fp.readline() | |
| 246 | 246 | if not line: | |
| 247 | - raise IndexError(f"Index file ended at line {i+1}, before given index was reached") | ||
| 247 | + raise IndexError(f"Index file ended at line {i + 1}, before given index was reached") | ||
| 248 | 248 | # END abort on eof | |
| 249 | 249 | # END handle runup | |
| 250 | 250 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1136,7 +1136,7 @@ class IterableClassWatcher(type): | |||
| 1136 | 1136 | ||
| 1137 | 1137 | def __init__(cls, name: str, bases: Tuple, clsdict: Dict) -> None: | |
| 1138 | 1138 | for base in bases: | |
| 1139 | - if type(base) == IterableClassWatcher: | ||
| 1139 | + if type(base) is IterableClassWatcher: | ||
| 1140 | 1140 | warnings.warn( | |
| 1141 | 1141 | f"GitPython Iterable subclassed by {name}. " | |
| 1142 | 1142 | "Iterable is deprecated due to naming clash since v3.1.18" | |
0 commit comments