Commit 9a0829d
authored
buffer: stricter argument checking in toString
This prevents the confusing behavior of `buf.toString(0, 5)` by
disallowing passing `0` as the encoding.
PR-URL: nodejs#11120
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 67af1ad commit 9a0829d
2 files changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -463,7 +463,7 @@ function slowToString(encoding, start, end) { | |||
| 463 | 463 | if (end <= start) | |
| 464 | 464 | return ''; | |
| 465 | 465 | ||
| 466 | - if (!encoding) encoding = 'utf8'; | ||
| 466 | + if (encoding === undefined) encoding = 'utf8'; | ||
| 467 | 467 | ||
| 468 | 468 | while (true) { | |
| 469 | 469 | switch (encoding) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -82,3 +82,11 @@ assert.strictEqual(rangeBuffer.toString('ascii', 0, true), 'a'); | |||
| 82 | 82 | assert.strictEqual(rangeBuffer.toString({toString: function() { | |
| 83 | 83 | return 'ascii'; | |
| 84 | 84 | }}), 'abc'); | |
| 85 | + | ||
| 86 | + // try toString() with 0 and null as the encoding | ||
| 87 | + assert.throws(() => { | ||
| 88 | + rangeBuffer.toString(0, 1, 2); | ||
| 89 | + }, /^TypeError: Unknown encoding: 0$/); | ||
| 90 | + assert.throws(() => { | ||
| 91 | + rangeBuffer.toString(null, 1, 2); | ||
| 92 | + }, /^TypeError: Unknown encoding: null$/); | ||
0 commit comments