Commit bf3de9b
perf(common): use ngDevMode to tree-shake warnings (#39964)
This commit adds ngDevMode guard to show warnings only
in dev mode (similar to how things work in other parts of Ivy runtime code).
The ngDevMode flag helps to tree-shake these warnings from production builds
(in dev mode everything will work as it works right now) to decrease production bundle size.
PR Close #399641 parent 2fbb684 commit bf3de9b
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,7 +6,7 @@ | |||
| 6 | 6 | * found in the LICENSE file at https://angular.io/license | |
| 7 | 7 | */ | |
| 8 | 8 | ||
| 9 | - import {Directive, DoCheck, EmbeddedViewRef, Input, isDevMode, IterableChangeRecord, IterableChanges, IterableDiffer, IterableDiffers, NgIterable, TemplateRef, TrackByFunction, ViewContainerRef} from '@angular/core'; | ||
| 9 | + import {Directive, DoCheck, EmbeddedViewRef, Input, IterableChangeRecord, IterableChanges, IterableDiffer, IterableDiffers, NgIterable, TemplateRef, TrackByFunction, ViewContainerRef} from '@angular/core'; | ||
| 10 | 10 | ||
| 11 | 11 | /** | |
| 12 | 12 | * @publicApi | |
@@ -159,7 +159,7 @@ export class NgForOf<T, U extends NgIterable<T> = NgIterable<T>> implements DoCh | |||
| 159 | 159 | */ | |
| 160 | 160 | @Input() | |
| 161 | 161 | set ngForTrackBy(fn: TrackByFunction<T>) { | |
| 162 | - if (isDevMode() && fn != null && typeof fn !== 'function') { | ||
| 162 | + if ((typeof ngDevMode === 'undefined' || ngDevMode) && fn != null && typeof fn !== 'function') { | ||
| 163 | 163 | // TODO(vicb): use a log service once there is a public one available | |
| 164 | 164 | if (<any>console && <any>console.warn) { | |
| 165 | 165 | console.warn( | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -241,7 +241,7 @@ export class CurrencyPipe implements PipeTransform { | |||
| 241 | 241 | locale = locale || this._locale; | |
| 242 | 242 | ||
| 243 | 243 | if (typeof display === 'boolean') { | |
| 244 | - if (<any>console && <any>console.warn) { | ||
| 244 | + if ((typeof ngDevMode === 'undefined' || ngDevMode) && <any>console && <any>console.warn) { | ||
| 245 | 245 | console.warn( | |
| 246 | 246 | `Warning: the currency pipe has been changed in Angular v5. The symbolDisplay option (third parameter) is now a string instead of a boolean. The accepted values are "code", "symbol" or "symbol-narrow".`); | |
| 247 | 247 | } | |
0 commit comments