perf(@angular/cli): optimize update schematic registry query counts b… · angular/angular-cli@4510dae · GitHub

angular / angular-cli Public

• Notifications You must be signed in to change notification settings
• Fork 11.8k
• Star 27k

• Code
• Issues 243
• Pull requests 21
• Actions
• Security and quality 5
• Insights

Additional navigation options

Commit 4510dae

Browse filesBrowse the repository at this point in the historyBrowse files

clydin

committed

perf(@angular/cli): optimize update schematic registry query counts by fetching package metadata lazily

Optimize the ng update registry requests by only querying package metadata for packages that are actually being updated, while resolving other dependencies locally from disk (with fallback to registry for uninstalled/mocked packages). This reduces network query counts by 80-90% during ng update. (cherry picked from commit 5e7508a)

1 parent a9b6bd9 commit 4510dae
Copy full SHA for 4510dae

4 files changed

+318-109Lines changed: 318 additions & 109 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/angular/cli/src/commands/update
  • cli.ts
  • schematic
    • index.ts
    • index_spec.ts
    • schema.json

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/angular/cli/src/commands/update/cli.ts‎

Copy file name to clipboardExpand all lines: packages/angular/cli/src/commands/update/cli.ts

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -256,6 +256,7 @@ export default class UpdateCommandModule extends CommandModule<UpdateCommandArgs
256	256	verbose: options.verbose,
257	257	packageManager: packageManager.name,
258	258	packages: [],
	259	+ workspaceRoot: this.context.root,
259	260	},
260	261	);
261	262
@@ -519,6 +520,7 @@ export default class UpdateCommandModule extends CommandModule<UpdateCommandArgs
519	520	next: options.next,
520	521	packageManager: this.context.packageManager.name,
521	522	packages: packagesToUpdate,
	523	+ workspaceRoot: this.context.root,
522	524	},
523	525	);
524	526

0 commit comments

Comments

0 (0)