Commit 930915a
committed
fix(@angular/cli): always install package during ng add to inspect manifest on disk for schematics
Private package registries such as GitHub Packages frequently strip out custom non-npm metadata properties (such as schematics and ng-add) from their remote API responses. Previously, ng add skipped confirming and installing a package if the registry metadata did not report hasSchematics, causing ng add to fail on first run.
This commit removes the early skip condition based on registry metadata so ng add always installs the target package to inspect its physical manifest on disk. If no schematics are found after installation, the CLI cleanly removes the temporary dependency.
Closes #330601 parent 74da7c1 commit 930915a
1 file changed
Lines changed: 6 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -224,29 +224,12 @@ export default class AddCommandModule | |||
| 224 | 224 | { | |
| 225 | 225 | title: 'Confirming installation', | |
| 226 | 226 | enabled: !skipConfirmation && !options.dryRun, | |
| 227 | - skip: (context) => { | ||
| 228 | - if (context.hasSchematics) { | ||
| 229 | - return false; | ||
| 230 | - } | ||
| 231 | - | ||
| 232 | - return `The ${color.blue(context.packageIdentifier.toString())} package does not provide \`ng add\` actions.`; | ||
| 233 | - }, | ||
| 234 | 227 | task: (context, task) => this.confirmInstallationTask(context, task), | |
| 235 | 228 | rendererOptions: { persistentOutput: true }, | |
| 236 | 229 | }, | |
| 237 | 230 | { | |
| 238 | 231 | title: 'Installing package', | |
| 239 | 232 | skip: (context) => { | |
| 240 | - if (!context.hasSchematics) { | ||
| 241 | - const builtInSchematic = | ||
| 242 | - BUILT_IN_SCHEMATICS[ | ||
| 243 | - context.packageIdentifier.name as keyof typeof BUILT_IN_SCHEMATICS | ||
| 244 | - ]; | ||
| 245 | - if (builtInSchematic) { | ||
| 246 | - return `Skipping package installation.`; | ||
| 247 | - } | ||
| 248 | - } | ||
| 249 | - | ||
| 250 | 233 | if (context.dryRun) { | |
| 251 | 234 | return `Skipping package installation. Would install package ${color.blue( | |
| 252 | 235 | context.packageIdentifier.toString(), | |
@@ -278,6 +261,9 @@ export default class AddCommandModule | |||
| 278 | 261 | if (localManifest['ng-add']?.save === false) { | |
| 279 | 262 | shouldCleanUp = true; | |
| 280 | 263 | } | |
| 264 | + } else { | ||
| 265 | + await this.cleanUpTemporaryDependency(result.collectionName); | ||
| 266 | + shouldCleanUp = false; | ||
| 281 | 267 | } | |
| 282 | 268 | } catch {} | |
| 283 | 269 | } | |
@@ -305,6 +291,9 @@ export default class AddCommandModule | |||
| 305 | 291 | const builtInSchematic = | |
| 306 | 292 | BUILT_IN_SCHEMATICS[packageName as keyof typeof BUILT_IN_SCHEMATICS]; | |
| 307 | 293 | if (builtInSchematic) { | |
| 294 | + logger.info( | ||
| 295 | + `The ${color.blue(packageName)} package does not provide \`ng add\` actions.`, | ||
| 296 | + ); | ||
| 308 | 297 | logger.info('The Angular CLI will use built-in actions to add it to your project.'); | |
| 309 | 298 | ||
| 310 | 299 | return this.executeSchematic({ | |
0 commit comments