fix(@angular-devkit/build-angular): do not consume inline sourcemaps … · angular/angular-cli@cea0280 · GitHub

angular / angular-cli Public

• Notifications You must be signed in to change notification settings
• Fork 11.8k
• Star 27k

• Code
• Issues 243
• Pull requests 21
• Actions
• Security and quality 5
• Insights

Additional navigation options

Commit cea0280

Browse filesBrowse the repository at this point in the historyBrowse files

alan-agius4

committed

fix(@angular-devkit/build-angular): do not consume inline sourcemaps when vendor sourcemaps is disabled.

Not removing inline sourcemaps when vendor sourcemaps is disabled causes an issue during the JS optimization sourcemap merging phase. ``` Optimization error [936.cf7797927c7f989bd40d.js]: Error: Transformation map 1 must have exactly one source file. ``` When vendor sourcemaps is disabled we are not interested into the said sourcemaps so now we remove the inline sourcemap. Closes #21508 (cherry picked from commit 2aa6f57)

1 parent 8dc3c89 commit cea0280
Copy full SHA for cea0280

1 file changed

+12-1Lines changed: 12 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/angular_devkit/build_angular/src/webpack/configs
  • common.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/angular_devkit/build_angular/src/webpack/configs/common.ts‎

Copy file name to clipboardExpand all lines: packages/angular_devkit/build_angular/src/webpack/configs/common.ts

+12-1Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -314,9 +314,20 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration {
314	314	if (scriptsSourceMap || stylesSourceMap) {
315	315	extraRules.push({
316	316	test: /\.m?js$/,
317		- exclude: vendorSourceMap ? undefined : /[\\\/]node_modules[\\\/]/,
318	317	enforce: 'pre',
319	318	loader: require.resolve('source-map-loader'),
	319	+ options: {
	320	+ filterSourceMappingUrl: (_mapUri: string, resourcePath: string) => {
	321	+ if (vendorSourceMap) {
	322	+ // Consume all sourcemaps when vendor option is enabled.
	323	+ return true;
	324	+ }
	325	+
	326	+ // Don't consume sourcemaps in node_modules when vendor is disabled.
	327	+ // But, do consume local libraries sourcemaps.
	328	+ return !resourcePath.includes('node_modules');
	329	+ },
	330	+ },
320	331	});
321	332	}
322	333

0 commit comments

Comments

0 (0)