Commit da74c6e
committed
Revert "fix(@angular-devkit/build-angular): control linker template sourcemapping via builder sourcemap options"
This reverts commit d4c5f85.
Following a debugging and investigation with @petebacondarwin it appears that when the external template handling in the linker generates Babel AST nodes that reference the external template files which breaks Babel when it tried to flatten final source-map, which ends up no emitting any source-maps.
As an interim solution we should revert this.
Closes #212711 parent 34e66ff commit da74c6e
2 files changed
Lines changed: 0 additions & 12 deletions
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -20,7 +20,6 @@ export interface ApplicationPresetOptions { | |||
| 20 | 20 | angularLinker?: { | |
| 21 | 21 | shouldLink: boolean; | |
| 22 | 22 | jitMode: boolean; | |
| 23 | - sourcemap: boolean; | ||
| 24 | 23 | }; | |
| 25 | 24 | ||
| 26 | 25 | forceES5?: boolean; | |
@@ -138,7 +137,6 @@ export default function (api: unknown, options: ApplicationPresetOptions) { | |||
| 138 | 137 | plugins.push( | |
| 139 | 138 | createEs2015LinkerPlugin({ | |
| 140 | 139 | linkerJitMode: options.angularLinker.jitMode, | |
| 141 | - sourceMapping: options.angularLinker.sourcemap, | ||
| 142 | 140 | logger: createNgtscLogger(options.diagnosticReporter), | |
| 143 | 141 | fileSystem: { | |
| 144 | 142 | resolve: path.resolve, | |
Lines changed: 0 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -58,7 +58,6 @@ export default custom<AngularCustomOptions>(() => { | |||
| 58 | 58 | customOptions.angularLinker = { | |
| 59 | 59 | shouldLink: true, | |
| 60 | 60 | jitMode: aot !== true, | |
| 61 | - sourcemap: false, | ||
| 62 | 61 | }; | |
| 63 | 62 | shouldProcess = true; | |
| 64 | 63 | } | |
@@ -141,15 +140,6 @@ export default custom<AngularCustomOptions>(() => { | |||
| 141 | 140 | ); | |
| 142 | 141 | } | |
| 143 | 142 | ||
| 144 | - // Only enable linker template sourcemapping if linker is enabled and Webpack provides | ||
| 145 | - // a sourcemap. This logic allows the linker sourcemap behavior to be controlled by the | ||
| 146 | - // Webpack sourcemap configuration. For example, if a vendor file is being processed | ||
| 147 | - // and vendor sourcemaps are disabled, the `inputSourceMap` property will be `undefined` | ||
| 148 | - // which will effectively disable linker sourcemapping for vendor files. | ||
| 149 | - if (customOptions.angularLinker && configuration.options.inputSourceMap) { | ||
| 150 | - customOptions.angularLinker.sourcemap = true; | ||
| 151 | - } | ||
| 152 | - | ||
| 153 | 143 | return { | |
| 154 | 144 | ...configuration.options, | |
| 155 | 145 | // Workaround for https://github.com/babel/babel-loader/pull/896 is available | |
0 commit comments