fix(webpack): don't use html-plugin in test · angular-fullstack/generator-angular-fullstack@959c31c · GitHub

This repository was archived by the owner on Jul 29, 2026. It is now read-only.

angular-fullstack / generator-angular-fullstack Public archive

• Notifications You must be signed in to change notification settings
• Fork 1.2k
• Star 6.1k

• Code
• Issues 243
• Pull requests 14
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 959c31c

Browse filesBrowse the repository at this point in the historyBrowse files

Awk34

committed

fix(webpack): don't use html-plugin in test

fixes #2374

1 parent 7781910 commit 959c31c
Copy full SHA for 959c31c

1 file changed

+10-8Lines changed: 10 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• templates/app
  • webpack.make.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎templates/app/webpack.make.js‎

Copy file name to clipboardExpand all lines: templates/app/webpack.make.js

+10-8Lines changed: 10 additions & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -321,15 +321,17 @@ module.exports = function makeWebpackConfig(options) {
321	321	// Skip rendering index.html in test mode
322	322	// Reference: https://github.com/ampedandwired/html-webpack-plugin
323	323	// Render index.html
324		- let htmlConfig = {
325		- template: 'client/_index.html',
326		- filename: '../client/index.html',
327		- alwaysWriteToDisk: true
	324	+ if(!TEST) {
	325	+ let htmlConfig = {
	326	+ template: 'client/_index.html',
	327	+ filename: '../client/index.html',
	328	+ alwaysWriteToDisk: true
	329	+ }
	330	+ config.plugins.push(
	331	+ new HtmlWebpackPlugin(htmlConfig),
	332	+ new HtmlWebpackHarddiskPlugin()
	333	+ );
328	334	}
329		- config.plugins.push(
330		- new HtmlWebpackPlugin(htmlConfig),
331		- new HtmlWebpackHarddiskPlugin()
332		- );
333	335
334	336	// Add build specific plugins
335	337	if(BUILD) {

0 commit comments

Comments

0 (0)