ARROW-15812: [R] Accept col_names in open_dataset for CSV - #14705
Conversation
Sorry, something went wrong.
Sorry, something went wrong.
There was a problem hiding this comment.
Given it's not used here, should we just remove the col_types argument entirely?
Sorry, something went wrong.
There was a problem hiding this comment.
OK, I see we use it later when we're listing which ones we do and do not support. Maybe this bit of the code needs refactoring in other ways, as it feels a bit brittle to depend on this here?
Sorry, something went wrong.
There was a problem hiding this comment.
Though probably out of scope for this PR
Sorry, something went wrong.
There was a problem hiding this comment.
Why this change?
Sorry, something went wrong.
There was a problem hiding this comment.
Ah looked at this again and I shouldn't have changed it. It was complaining that skip was a readr style arg, but we were internally appending an Arrow-style arg column_names when we passed an explicit schema. It's a little messy, but I basically changed it so internally we choose to add column_names (Arrow-style) or col_names (readr-style) based on what other arguments were passed.
Sorry, something went wrong.
thisisnic
left a comment
There was a problem hiding this comment.
Thanks for making this change! Just a few comments.
Sorry, something went wrong.
Co-authored-by: Nic Crane <thisisnic@gmail.com>
|
Benchmark runs are scheduled for baseline = 37f5a35 and contender = 211925c. 211925c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Sorry, something went wrong.
Lead-authored-by: Will Jones <willjones127@gmail.com> Co-authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
No description provided.