| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports: PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also: |
Sorry, something went wrong.
|
⚠️ GitHub issue #38216 has been automatically assigned in GitHub to PR creator. |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks for making this PR, @Divyansh200102! A couple of things to suggest:
Lines 114 to 115 in 4bf777a
Then, if you run devtools::document() in R the change in open_dataset.Rd will be automatically generated. (if you're only making the changes in the GitHub editor, let me know and I can run devtools::document() myself and push the change for you)
Sorry, something went wrong.
|
is it fine now? and for some reason i am not able to setup the r so can you run devtools::document() in R and push the changes in open_dataset.Rd in yourself |
Sorry, something went wrong.
|
Great, the comment is in the right file! Just needs updating to refer to newline-delimited JSON rather than just JSON. |
Sorry, something went wrong.
|
@github-actions autotune |
Sorry, something went wrong.
|
I tried to fix the docs on using out bot, but looks like the github bot can’t push to this fork: https://github.com/apache/arrow/actions/runs/6550133348/job/17788582932#step:13:8 I'm not sure if this is something you've configured @Divyansh200102 to disallow pushes to your fork from upstream, or if it's something that is wrong with the bot generally. |
Sorry, something went wrong.
shall i create a new pull request?? |
Sorry, something went wrong.
Nope, don't worry about it — I pulled it locally and updated them. Once the CI is green I'll approve + merge. Thanks for your contribution! |
Sorry, something went wrong.
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit ac581fd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sorry, something went wrong.
…che#38258) fixes apache#38216 * Closes: apache#38216 Lead-authored-by: Divyansh200102 <divyanshkhatri200102@gmail.com> Co-authored-by: Divyansh200102 <146909065+Divyansh200102@users.noreply.github.com> Co-authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
…che#38258) fixes apache#38216 * Closes: apache#38216 Lead-authored-by: Divyansh200102 <divyanshkhatri200102@gmail.com> Co-authored-by: Divyansh200102 <146909065+Divyansh200102@users.noreply.github.com> Co-authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
| Back | FazBrowse Home | New Git URL |
fixes #38216