[To dev/1.3] Upgrade Eclipse Milo to 1.1.6 (#18431) - #18442
Draft
Caideyipi wants to merge 3 commits into
Draft
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
* Upgrade Eclipse Milo to 1.1.6 * Add OPC UA TCP None compatibility test * Update dependency manifest for Milo 1.1.6 * CI fix
…43e73-dev-1.3 # Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/OpcUaSink.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/client/IoTDBOpcUaClient.java # iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/client/IoTDBOpcUaClientTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick 02f43e73f4705186210c2ec9d7e07bb16827b2a5 from master to dev/1.3.
Original PR: #18431
This upgrades Eclipse Milo from 0.6.14 to 1.1.6, migrates the OPC UA server/client code to the Milo 1.x APIs, and carries over the security hardening and TCP None compatibility coverage from the original change.
Draft blocker: Java baseline incompatibility
dev/1.3 compiles with maven.compiler.release=8, while the Milo 1.1.6 artifacts use Java 17 bytecode (class-file major version 61). Milo 1.1.6 types also use Java 17 classes such as java.lang.Record; for example, org.eclipse.milo.opcua.stack.core.types.builtin.DateTime extends java.lang.Record.
The focused DataNode build therefore currently fails during compilation under the dev/1.3 Java 8 target. Before this PR can be made ready, the branch needs a decision on whether to raise its Java baseline or use a Java 8-compatible upstream remediation. This draft intentionally keeps the cherry-pick close to the original change while that decision is pending.
Verification
This PR has:
Key changed/added classes