ci: Alert Slack on failure across CI workflows - #1912
Conversation
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1912 +/- ##
==========================================
- Coverage 92.92% 92.90% -0.02%
==========================================
Files 167 167
Lines 11714 11714
==========================================
- Hits 10885 10883 -2
- Misses 829 831 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
There was a problem hiding this comment.
Is this really worth a Slack notification? If so, maybe we should just set up an org-level hook to monitor all failed workflow runs...
Sorry, something went wrong.
There was a problem hiding this comment.
You mean just on_issue, right? And the rest is ok?
Agreed, it's not really needed there.
For the other workflows, I'd like to have them - mostly for myself, so I have a single place that notifies me about failing runs, instead of having to check each repo manually.
Sorry, something went wrong.
There was a problem hiding this comment.
As long as it saves work, it's a good thing to have. But if you want to monitor more repositories than just this one, I still think that an organization-level webhook would be less intrusive 🙂
Sorry, something went wrong.
There was a problem hiding this comment.
As long as it saves work, it's a good thing to have. But if you want to monitor more repositories than just this one, I still think that an organization-level webhook would be less intrusive 🙂
Sorry, something went wrong.
Let's make "Notify Slack on failure" reusable, and reuse it across other places where it makes sense. Apply it to other Python repos once this is merged.