fix(method-definition): add missing request parameter in method (#11) · apimatic/core-interfaces-python@35552c0 · GitHub

apimatic / core-interfaces-python Public

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Issues
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 35552c0

Browse filesBrowse the repository at this point in the historyBrowse files

sufyankhanrao

authored

fix(method-definition): add missing request parameter in method (#11)

This commit bears the fix for the method definition in HttpClient class where convert_response method has a parameter missing in the definition. This change adds a request parameter of type HttpRequest in the method definition. closes #10

1 parent f7750b9 commit 35552c0
Copy full SHA for 35552c0

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• apimatic_core_interfaces/client
  • http_client.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎apimatic_core_interfaces/client/http_client.py‎

Copy file name to clipboardExpand all lines: apimatic_core_interfaces/client/http_client.py

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -25,13 +25,14 @@ def execute(self, request, endpoint_configuration):
25	25	...
26	26
27	27	@abstractmethod
28		- def convert_response(self, response, contains_binary_response):
	28	+ def convert_response(self, response, contains_binary_response, request):
29	29	"""Converts the Response object of the HttpClient into an
30	30	HttpResponse object.
31	31
32	32	Args:
33	33	response (dynamic): The original response object.
34	34	contains_binary_response (bool): The flag to check if the response is of binary type.
	35	+ request (HttpRequest): The original HttpRequest object.
35	36
36	37	Returns:
37	38	HttpResponse: The converted HttpResponse object.

0 commit comments

Comments

0 (0)