cppcheck/test/testclass.cpp at master · applsdev/cppcheck · GitHub

History

6234 lines (5639 loc) · 225 KB

Raw

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

115

116

117

118

119

120

121

122

123

124

125

126

127

128

129

130

131

132

133

134

135

136

137

138

139

140

141

142

143

144

145

146

147

148

149

150

151

152

153

154

155

156

157

158

159

160

161

162

163

164

165

166

167

168

169

170

171

172

173

174

175

176

177

178

179

180

181

182

183

184

185

186

187

188

189

190

191

192

193

194

195

196

197

198

199

200

201

202

203

204

205

206

207

208

209

210

211

212

213

214

215

216

217

218

219

220

221

222

223

224

225

226

227

228

229

230

231

232

233

234

235

236

237

238

239

240

241

242

243

244

245

246

247

248

249

250

251

252

253

254

255

256

257

258

259

260

261

262

263

264

265

266

267

268

269

270

271

272

273

274

275

276

277

278

279

280

281

282

283

284

285

286

287

288

289

290

291

292

293

294

295

296

297

298

299

300

301

302

303

304

305

306

307

308

309

310

311

312

313

314

315

316

317

318

319

320

321

322

323

324

325

326

327

328

329

330

331

332

333

334

335

336

337

338

339

340

341

342

343

344

345

346

347

348

349

350

351

352

353

354

355

356

357

358

359

360

361

362

363

364

365

366

367

368

369

370

371

372

373

374

375

376

377

378

379

380

381

382

383

384

385

386

387

388

389

390

391

392

393

394

395

396

397

398

399

400

401

402

403

404

405

406

407

408

409

410

411

412

413

414

415

416

417

418

419

420

421

422

423

424

425

426

427

428

429

430

431

432

433

434

435

436

437

438

439

440

441

442

443

444

445

446

447

448

449

450

451

452

453

454

455

456

457

458

459

460

461

462

463

464

465

466

467

468

469

470

471

472

473

474

475

476

477

478

479

480

481

482

483

484

485

486

487

488

489

490

491

492

493

494

495

496

497

498

499

500

501

502

503

504

505

506

507

508

509

510

511

512

513

514

515

516

517

518

519

520

521

522

523

524

525

526

527

528

529

530

531

532

533

534

535

536

537

538

539

540

541

542

543

544

545

546

547

548

549

550

551

552

553

554

555

556

557

558

559

560

561

562

563

564

565

566

567

568

569

570

571

572

573

574

575

576

577

578

579

580

581

582

583

584

585

586

587

588

589

590

591

592

593

594

595

596

597

598

599

600

601

602

603

604

605

606

607

608

609

610

611

612

613

614

615

616

617

618

619

620

621

622

623

624

625

626

627

628

629

630

631

632

633

634

635

636

637

638

639

640

641

642

643

644

645

646

647

648

649

650

651

652

653

654

655

656

657

658

659

660

661

662

663

664

665

666

667

668

669

670

671

672

673

674

675

676

677

678

679

680

681

682

683

684

685

686

687

688

689

690

691

692

693

694

695

696

697

698

699

700

701

702

703

704

705

706

707

708

709

710

711

712

713

714

715

716

717

718

719

720

721

722

723

724

725

726

727

728

729

730

731

732

733

734

735

736

737

738

739

740

741

742

743

744

745

746

747

748

749

750

751

752

753

754

755

756

757

758

759

760

761

762

763

764

765

766

767

768

769

770

771

772

773

774

775

776

777

778

779

780

781

782

783

784

785

786

787

788

789

790

791

792

793

794

795

796

797

798

799

800

801

802

803

804

805

806

807

808

809

810

811

812

813

814

815

816

817

818

819

820

821

822

823

824

825

826

827

828

829

830

831

832

833

834

835

836

837

838

839

840

841

842

843

844

845

846

847

848

849

850

851

852

853

854

855

856

857

858

859

860

861

862

863

864

865

866

867

868

869

870

871

872

873

874

875

876

877

878

879

880

881

882

883

884

885

886

887

888

889

890

891

892

893

894

895

896

897

898

899

900

901

902

903

904

905

906

907

908

909

910

911

912

913

914

915

916

917

918

919

920

921

922

923

924

925

926

927

928

929

930

931

932

933

934

935

936

937

938

939

940

941

942

943

944

945

946

947

948

949

950

951

952

953

954

955

956

957

958

959

960

961

962

963

964

965

966

967

968

969

970

971

972

973

974

975

976

977

978

979

980

981

982

983

984

985

986

987

988

989

990

991

992

993

994

995

996

997

998

999

1000

* Cppcheck - A tool for static C/C++ code analysis

* This program is free software: you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation, either version 3 of the License, or

* (at your option) any later version.

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

* You should have received a copy of the GNU General Public License

* along with this program. If not, see <http://www.gnu.org/licenses/>.

#include "tokenize.h"

#include "checkclass.h"

#include "testsuite.h"

#include <sstream>

extern std::ostringstream errout;

class TestClass : public TestFixture

{

public:

TestClass() : TestFixture("TestClass")

{ }

private:

void run()

{

TEST_CASE(virtualDestructor1); // Base class not found => no error

TEST_CASE(virtualDestructor2); // Base class doesn't have a destructor

TEST_CASE(virtualDestructor3); // Base class has a destructor, but it's not virtual

TEST_CASE(virtualDestructor4); // Derived class doesn't have a destructor => no error

TEST_CASE(virtualDestructor5); // Derived class has empty destructor => no error

TEST_CASE(virtualDestructor6); // only report error if base class pointer that points at derived class is deleted

TEST_CASE(virtualDestructorProtected);

TEST_CASE(virtualDestructorInherited);

TEST_CASE(virtualDestructorTemplate);

TEST_CASE(uninitVar1);

TEST_CASE(uninitVar2);

TEST_CASE(uninitVar3);

TEST_CASE(uninitVar4);

TEST_CASE(uninitVar5);

TEST_CASE(uninitVar6);

TEST_CASE(uninitVar7);

TEST_CASE(uninitVar8);

TEST_CASE(uninitVar9); // ticket #1730

TEST_CASE(uninitVar10); // ticket #1993

TEST_CASE(uninitVar11);

TEST_CASE(uninitVar12); // ticket #2078

TEST_CASE(uninitVar13); // ticket #1195

TEST_CASE(uninitVar14); // ticket #2149

TEST_CASE(uninitVar15);

TEST_CASE(uninitVar16);

TEST_CASE(uninitVar17);

TEST_CASE(uninitVar18); // ticket #2465

TEST_CASE(uninitVar19); // ticket #2792

TEST_CASE(uninitVar20); // ticket #2867

TEST_CASE(uninitVarEnum);

TEST_CASE(uninitVarStream);

TEST_CASE(uninitVarTypedef);

TEST_CASE(uninitVarMemset);

TEST_CASE(uninitVarArray1);

TEST_CASE(uninitVarArray2);

TEST_CASE(uninitVarArray3);

TEST_CASE(uninitVarArray4);

TEST_CASE(uninitVarArray5);

TEST_CASE(uninitVarArray6);

TEST_CASE(uninitVarArray2D);

TEST_CASE(uninitVarStruct1); // ticket #2172

TEST_CASE(uninitVarStruct2); // ticket #838

TEST_CASE(uninitMissingFuncDef); // can't expand function in constructor

TEST_CASE(privateCtor1); // If constructor is private..

TEST_CASE(privateCtor2); // If constructor is private..

TEST_CASE(function); // Function is not variable

TEST_CASE(uninitVarHeader1); // Class is defined in header

TEST_CASE(uninitVarHeader2); // Class is defined in header

TEST_CASE(uninitVarHeader3); // Class is defined in header

TEST_CASE(uninitVarPublished); // Borland C++: Variables in the published section are auto-initialized

TEST_CASE(uninitOperator); // No FP about uninitialized 'operator[]'

TEST_CASE(uninitFunction1); // No FP when initialized in function

TEST_CASE(uninitFunction2); // No FP when initialized in function

TEST_CASE(uninitFunction3); // No FP when initialized in function

TEST_CASE(uninitFunction4);

TEST_CASE(uninitSameClassName); // No FP when two classes have the same name

TEST_CASE(uninitFunctionOverload); // No FP when there are overloaded functions

TEST_CASE(uninitJava); // Java: no FP when variable is initialized in declaration

TEST_CASE(uninitVarOperatorEqual); // ticket #2415

TEST_CASE(noConstructor1);

TEST_CASE(noConstructor2);

TEST_CASE(noConstructor3);

TEST_CASE(noConstructor4);

TEST_CASE(noConstructor5);

TEST_CASE(operatorEq1);

TEST_CASE(operatorEq2);

TEST_CASE(operatorEqRetRefThis1);

TEST_CASE(operatorEqRetRefThis2); // ticket #1323

TEST_CASE(operatorEqRetRefThis3); // ticket #1405

TEST_CASE(operatorEqRetRefThis4); // ticket #1451

TEST_CASE(operatorEqRetRefThis5); // ticket #1550

TEST_CASE(operatorEqRetRefThis6); // ticket #2479

TEST_CASE(operatorEqToSelf1); // single class

TEST_CASE(operatorEqToSelf2); // nested class

TEST_CASE(operatorEqToSelf3); // multiple inheritance

TEST_CASE(operatorEqToSelf4); // nested class with multiple inheritance

TEST_CASE(operatorEqToSelf5); // ticket # 1233

TEST_CASE(operatorEqToSelf6); // ticket # 1550

TEST_CASE(operatorEqToSelf7);

TEST_CASE(operatorEqToSelf8); // ticket #2179

TEST_CASE(operatorEqToSelf9); // ticket #2592

TEST_CASE(memsetOnStruct);

TEST_CASE(memsetVector);

TEST_CASE(memsetOnClass);

TEST_CASE(this_subtraction); // warn about "this-x"

// can member function be made const

TEST_CASE(const1);

TEST_CASE(const2);

TEST_CASE(const3);

TEST_CASE(const4);

TEST_CASE(const5); // ticket #1482

TEST_CASE(const6); // ticket #1491

TEST_CASE(const7);

TEST_CASE(const8); // ticket #1517

TEST_CASE(const9); // ticket #1515

TEST_CASE(const10); // ticket #1522

TEST_CASE(const11); // ticket #1529

TEST_CASE(const12); // ticket #1552

TEST_CASE(const13); // ticket #1519

TEST_CASE(const14);

TEST_CASE(const15);

TEST_CASE(const16); // ticket #1551

TEST_CASE(const17); // ticket #1552

TEST_CASE(const18); // ticket #1563

TEST_CASE(const19); // ticket #1612

TEST_CASE(const20); // ticket #1602

TEST_CASE(const21); // ticket #1683

TEST_CASE(const22);

TEST_CASE(const23); // ticket #1699

TEST_CASE(const24); // ticket #1708

TEST_CASE(const25); // ticket #1724

TEST_CASE(const26); // ticket #1847

TEST_CASE(const27); // ticket #1882

TEST_CASE(const28); // ticket #1883

TEST_CASE(const29); // ticket #1922

TEST_CASE(const30);

TEST_CASE(const31);

TEST_CASE(const32); // ticket #1905 - member array is assigned

TEST_CASE(const33);

TEST_CASE(const34); // ticket #1964

TEST_CASE(const35); // ticket #2001

TEST_CASE(const36); // ticket #2003

TEST_CASE(const37); // ticket #2081 and #2085

TEST_CASE(const38); // ticket #2135

TEST_CASE(const39);

TEST_CASE(const40); // ticket #2228

TEST_CASE(const41); // ticket #2255

TEST_CASE(const42); // ticket #2282

TEST_CASE(const43); // ticket #2377

TEST_CASE(const44); // ticket #2595

TEST_CASE(const45); // ticket #2664

TEST_CASE(const46); // ticket #2636

TEST_CASE(const47); // ticket #2670

TEST_CASE(const48); // ticket #2672

TEST_CASE(const49); // ticket #2795

TEST_CASE(assigningPointerToPointerIsNotAConstOperation);

TEST_CASE(assigningArrayElementIsNotAConstOperation);

TEST_CASE(constoperator1); // operator< can often be const

TEST_CASE(constoperator2); // operator<<

TEST_CASE(constoperator3);

TEST_CASE(constoperator4);

TEST_CASE(constincdec); // increment/decrement => non-const

TEST_CASE(constassign1);

TEST_CASE(constassign2);

TEST_CASE(constincdecarray); // increment/decrement array element => non-const

TEST_CASE(constassignarray);

TEST_CASE(constReturnReference);

TEST_CASE(constDelete); // delete member variable => not const

TEST_CASE(constLPVOID); // a function that returns LPVOID can't be const

TEST_CASE(constFunc); // a function that calls const functions can be const

TEST_CASE(constVirtualFunc);

TEST_CASE(constIfCfg); // ticket #1881 - fp when there are #if

TEST_CASE(constFriend); // ticket #1921 - fp for friend function

TEST_CASE(constUnion); // ticket #2111 - fp when there are union

}

// Check the operator Equal

void checkOpertorEq(const char code[])

{

// Clear the error log

errout.str("");

Settings settings;

settings._checkCodingStyle = true;

// Tokenize..

Tokenizer tokenizer(&settings, this);

std::istringstream istr(code);

tokenizer.tokenize(istr, "test.cpp");

tokenizer.simplifyTokenList();

// Check..

CheckClass checkClass(&tokenizer, &settings, this);

checkClass.operatorEq();

}

void operatorEq1()

{

checkOpertorEq("class A\n"

"{\n"

"public:\n"

" void goo() {}"

" void operator=(const A&);\n"

"};\n");

ASSERT_EQUALS("[test.cpp:4]: (style) 'A::operator=' should return 'A &'\n", errout.str());

checkOpertorEq("class A\n"

"{\n"

"private:\n"

" void operator=(const A&);\n"

"};\n");

ASSERT_EQUALS("", errout.str());

checkOpertorEq("class A\n"

"{\n"

" void operator=(const A&);\n"

"};\n");

ASSERT_EQUALS("", errout.str());

checkOpertorEq("class A\n"

"{\n"

"public:\n"

" void goo() {}\n"

"private:\n"

" void operator=(const A&);\n"

"};\n");

ASSERT_EQUALS("", errout.str());

checkOpertorEq("class A\n"

"{\n"

"public:\n"

" void operator=(const A&);\n"

"};\n"

"class B\n"

"{\n"

"public:\n"

" void operator=(const B&);\n"

"};\n");

ASSERT_EQUALS("[test.cpp:4]: (style) 'A::operator=' should return 'A &'\n"

"[test.cpp:9]: (style) 'B::operator=' should return 'B &'\n", errout.str());

checkOpertorEq("struct A\n"

"{\n"

" void operator=(const A&);\n"

"};\n");

ASSERT_EQUALS("[test.cpp:3]: (style) 'A::operator=' should return 'A &'\n", errout.str());

}

void operatorEq2()

{

checkOpertorEq("class A\n"

"{\n"

"public:\n"

" void * operator=(const A&);\n"

"};\n");

ASSERT_EQUALS("[test.cpp:4]: (style) 'A::operator=' should return 'A &'\n", errout.str());

checkOpertorEq("class A\n"

"{\n"

"public:\n"

" A * operator=(const A&);\n"

"};\n");

ASSERT_EQUALS("[test.cpp:4]: (style) 'A::operator=' should return 'A &'\n", errout.str());

checkOpertorEq("class A\n"

"{\n"

"public:\n"

" const A & operator=(const A&);\n"

"};\n");

ASSERT_EQUALS("[test.cpp:4]: (style) 'A::operator=' should return 'A &'\n", errout.str());

checkOpertorEq("class A\n"

"{\n"

"public:\n"

" B & operator=(const A&);\n"

"};\n");

ASSERT_EQUALS("[test.cpp:4]: (style) 'A::operator=' should return 'A &'\n", errout.str());

}

// Check that operator Equal returns reference to this

void checkOpertorEqRetRefThis(const char code[])

{

// Clear the error log

errout.str("");

Settings settings;

settings._checkCodingStyle = true;

// Tokenize..

Tokenizer tokenizer(&settings, this);

std::istringstream istr(code);

tokenizer.tokenize(istr, "test.cpp");

tokenizer.simplifyTokenList();

// Check..

CheckClass checkClass(&tokenizer, &settings, this);

checkClass.operatorEqRetRefThis();

}

void operatorEqRetRefThis1()

{

checkOpertorEqRetRefThis(

"class A\n"

"{\n"

"public:\n"

" A & operator=(const A &a) { return *this; }\n"

"};\n");

ASSERT_EQUALS("", errout.str());

checkOpertorEqRetRefThis(

"class A\n"

"{\n"

"public:\n"

" A & operator=(const A &a) { return a; }\n"

"};\n");

ASSERT_EQUALS("[test.cpp:4]: (style) 'operator=' should return reference to self\n", errout.str());

checkOpertorEqRetRefThis(

"class A\n"

"{\n"

"public:\n"

" A & operator=(const A &);\n"

"};\n"

"A & A::operator=(const A &a) { return *this; }\n");

ASSERT_EQUALS("", errout.str());

checkOpertorEqRetRefThis(

"class A\n"

"{\n"

"public:\n"

" A & operator=(const A &a);\n"

"};\n"

"A & A::operator=(const A &a) { return *this; }\n");

ASSERT_EQUALS("", errout.str());

checkOpertorEqRetRefThis(

"class A\n"

"{\n"

"public:\n"

" A & operator=(const A &);\n"

"};\n"

"A & A::operator=(const A &a) { return a; }\n");

ASSERT_EQUALS("[test.cpp:6]: (style) 'operator=' should return reference to self\n", errout.str());

checkOpertorEqRetRefThis(

"class A\n"

"{\n"

"public:\n"

" A & operator=(const A &a);\n"

"};\n"

"A & A::operator=(const A &a) { return a; }\n");

ASSERT_EQUALS("[test.cpp:6]: (style) 'operator=' should return reference to self\n", errout.str());

checkOpertorEqRetRefThis(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" B & operator=(const B &b) { return *this; }\n"

" };\n"

"};\n");

ASSERT_EQUALS("", errout.str());

checkOpertorEqRetRefThis(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" B & operator=(const B &b) { return b; }\n"

" };\n"

"};\n");

ASSERT_EQUALS("[test.cpp:7]: (style) 'operator=' should return reference to self\n", errout.str());

checkOpertorEqRetRefThis(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" B & operator=(const B &);\n"

" };\n"

"};\n"

"A::B & A::B::operator=(const A::B &b) { return *this; }\n");

ASSERT_EQUALS("", errout.str());

checkOpertorEqRetRefThis(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" B & operator=(const B &);\n"

" };\n"

"};\n"

"A::B & A::B::operator=(const A::B &b) { return b; }\n");

ASSERT_EQUALS("[test.cpp:10]: (style) 'operator=' should return reference to self\n", errout.str());

}

void operatorEqRetRefThis2()

{

// ticket # 1323

checkOpertorEqRetRefThis(

"class szp\n"

"{\n"

" szp &operator =(int *other) {};\n"

"};");

ASSERT_EQUALS("[test.cpp:3]: (style) 'operator=' should return reference to self\n", errout.str());

checkOpertorEqRetRefThis(

"class szp\n"

"{\n"

" szp &operator =(int *other);\n"

"};\n"

"szp &szp::operator =(int *other) {}");

ASSERT_EQUALS("[test.cpp:5]: (style) 'operator=' should return reference to self\n", errout.str());

}

void operatorEqRetRefThis3()

{

// ticket # 1405

checkOpertorEqRetRefThis(

"class A {\n"

"public:\n"

" inline A &operator =(int *other) { return (*this;) };\n"

" inline A &operator =(long *other) { return (*this = 0;) };\n"

"};");

ASSERT_EQUALS("", errout.str());

checkOpertorEqRetRefThis(

"class A {\n"

"public:\n"

" A &operator =(int *other);\n"

" A &operator =(long *other);\n"

"};\n"

"A &A::operator =(int *other) { return (*this;) };\n"

"A &A::operator =(long *other) { return (*this = 0;) };");

ASSERT_EQUALS("", errout.str());

checkOpertorEqRetRefThis(

"class A {\n"

"public:\n"

" inline A &operator =(int *other) { return (*this;) };\n"

" inline A &operator =(long *other) { return operator = (*(int *)other); };\n"

"};");

ASSERT_EQUALS("", errout.str());

checkOpertorEqRetRefThis(

"class A {\n"

"public:\n"

" A &operator =(int *other);\n"

" A &operator =(long *other);\n"

"};\n"

"A &A::operator =(int *other) { return (*this;) };\n"

"A &A::operator =(long *other) { return operator = (*(int *)other); };");

ASSERT_EQUALS("", errout.str());

checkOpertorEqRetRefThis(

"class A {\n"

"public:\n"

" A &operator =(int *other);\n"

" A &operator =(long *other);\n"

"};\n"

"A &A::operator =(int *other) { return (*this;) };\n"

"A &A::operator =(long *other) { return this->operator = (*(int *)other); };");

ASSERT_EQUALS("", errout.str());

}

void operatorEqRetRefThis4()

{

// ticket # 1451

checkOpertorEqRetRefThis(

"P& P::operator = (const P& pc)\n"

"{\n"

" return (P&)(*this += pc);\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void operatorEqRetRefThis5()

{

// ticket # 1550

checkOpertorEqRetRefThis(

"class A {\n"

"public:\n"

" A & operator=(const A &a) { }\n"

"};");

ASSERT_EQUALS("[test.cpp:3]: (style) 'operator=' should return reference to self\n", errout.str());

checkOpertorEqRetRefThis(

"class A {\n"

"public:\n"

" A & operator=(const A &a);\n"

"};\n"

"A & A :: operator=(const A &a) { }");

ASSERT_EQUALS("[test.cpp:5]: (style) 'operator=' should return reference to self\n", errout.str());

}

void operatorEqRetRefThis6() // ticket #2478 (segmentation fault)

{

checkOpertorEqRetRefThis(

"class UString {\n"

"public:\n"

" UString& assign( const char* c_str );\n"

" UString& operator=( const UString& s );\n"

"};\n"

"UString& UString::assign( const char* c_str ) {\n"

" std::string tmp( c_str );\n"

" return assign( tmp );\n"

"}\n"

"UString& UString::operator=( const UString& s ) {\n"

" return assign( s );\n"

"}\n");

}

// Check that operator Equal checks for assignment to self

void checkOpertorEqToSelf(const char code[])

{

// Clear the error log

errout.str("");

Settings settings;

settings._checkCodingStyle = true;

// Tokenize..

Tokenizer tokenizer(&settings, this);

std::istringstream istr(code);

tokenizer.tokenize(istr, "test.cpp");

tokenizer.simplifyTokenList();

// Check..

CheckClass checkClass(&tokenizer, &settings, this);

checkClass.operatorEqToSelf();

}

void operatorEqToSelf1()

{

// this test has an assignment test but it is not needed

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" A & operator=(const A &a) { if (&a != this) { } return *this; }\n"

"};\n");

ASSERT_EQUALS("", errout.str());

// this test doesn't have an assignment test but it is not needed

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" A & operator=(const A &a) { return *this; }\n"

"};\n");

ASSERT_EQUALS("", errout.str());

// this test needs an assignment test and has it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" char *s;\n"

" A & operator=(const A &a)\n"

" {\n"

" if (&a != this)\n"

" {\n"

" free(s);\n"

" s = strdup(a.s);\n"

" }\n"

" return *this;\n"

" }\n"

"};\n");

ASSERT_EQUALS("", errout.str());

// this class needs an assignment test but doesn't have it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" char *s;\n"

" A & operator=(const A &a)\n"

" {\n"

" free(s);\n"

" s = strdup(a.s);\n"

" return *this;\n"

" }\n"

"};\n");

ASSERT_EQUALS("[test.cpp:5]: (warning) 'operator=' should check for assignment to self\n", errout.str());

// this test has an assignment test but doesn't need it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" A & operator=(const A &);\n"

"};\n"

"A & A::operator=(const A &a) { if (&a != this) { } return *this; }\n");

ASSERT_EQUALS("", errout.str());

// this test doesn't have an assignment test but doesn't need it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" A & operator=(const A &);\n"

"};\n"

"A & A::operator=(const A &a) { return *this; }\n");

ASSERT_EQUALS("", errout.str());

// this test needs an assignment test and has it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" char *s;\n"

" A & operator=(const A &);\n"

"};\n"

"A & A::operator=(const A &a)\n"

"{\n"

" if (&a != this)\n"

" {\n"

" free(s);\n"

" s = strdup(a.s);\n"

" }\n"

" return *this;\n"

"}\n");

ASSERT_EQUALS("", errout.str());

// this test needs an assignment test but doesn’t have it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" char *s;\n"

" A & operator=(const A &);\n"

"};\n"

"A & A::operator=(const A &a)\n"

"{\n"

" free(s);\n"

" s = strdup(a.s);\n"

" return *this;\n"

"}\n");

ASSERT_EQUALS("[test.cpp:7]: (warning) 'operator=' should check for assignment to self\n", errout.str());

// ticket #1224

checkOpertorEqToSelf(

"const SubTree &SubTree::operator= (const SubTree &b)\n"

"{\n"

" CodeTree *oldtree = tree;\n"

" tree = new CodeTree(*b.tree);\n"

" delete oldtree;\n"

" return *this;\n"

"}\n"

"const SubTree &SubTree::operator= (const CodeTree &b)\n"

"{\n"

" CodeTree *oldtree = tree;\n"

" tree = new CodeTree(b);\n"

" delete oldtree;\n"

" return *this;\n"

"}");

ASSERT_EQUALS("", errout.str());

}

void operatorEqToSelf2()

{

// this test has an assignment test but doesn't need it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" B & operator=(const B &b) { if (&b != this) { } return *this; }\n"

" };\n"

"};\n");

ASSERT_EQUALS("", errout.str());

// this test doesn't have an assignment test but doesn't need it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" B & operator=(const B &b) { return *this; }\n"

" };\n"

"};\n");

ASSERT_EQUALS("", errout.str());

// this test needs an assignment test but has it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" char *s;\n"

" B & operator=(const B &b)\n"

" {\n"

" if (&b != this)\n"

" {\n"

" }\n"

" return *this;\n"

" }\n"

" };\n"

"};\n");

ASSERT_EQUALS("", errout.str());

// this test needs an assignment test but doesn't have it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" char *s;\n"

" B & operator=(const B &b)\n"

" {\n"

" free(s);\n"

" s = strdup(b.s);\n"

" return *this;\n"

" }\n"

" };\n"

"};\n");

ASSERT_EQUALS("[test.cpp:8]: (warning) 'operator=' should check for assignment to self\n", errout.str());

// this test has an assignment test but doesn't need it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" B & operator=(const B &);\n"

" };\n"

"};\n"

"A::B & A::B::operator=(const A::B &b) { if (&b != this) { } return *this; }\n");

ASSERT_EQUALS("", errout.str());

// this test doesn't have an assignment test but doesn't need it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" B & operator=(const B &);\n"

" };\n"

"};\n"

"A::B & A::B::operator=(const A::B &b) { return *this; }\n");

ASSERT_EQUALS("", errout.str());

// this test needs an assignment test and has it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" char * s;\n"

" B & operator=(const B &);\n"

" };\n"

"};\n"

"A::B & A::B::operator=(const A::B &b)\n"

"{\n"

" if (&b != this)\n"

" {\n"

" free(s);\n"

" s = strdup(b.s);\n"

" }\n"

" return *this;\n"

" }\n");

ASSERT_EQUALS("", errout.str());

// this test needs an assignment test but doesn't have it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B\n"

" {\n"

" public:\n"

" char * s;\n"

" B & operator=(const B &);\n"

" };\n"

"};\n"

"A::B & A::B::operator=(const A::B &b)\n"

"{\n"

" free(s);\n"

" s = strdup(b.s);\n"

" return *this;\n"

" }\n");

ASSERT_EQUALS("[test.cpp:11]: (warning) 'operator=' should check for assignment to self\n", errout.str());

}

void operatorEqToSelf3()

{

// this test has multiple inheritance so there is no trivial way to test for self assignment but doesn't need it

checkOpertorEqToSelf(

"class A : public B, public C\n"

"{\n"

"public:\n"

" A & operator=(const A &a) { return *this; }\n"

"};\n");

ASSERT_EQUALS("", errout.str());

// this test has multiple inheritance and needs an assignment test but there is no trivial way to test for it

checkOpertorEqToSelf(

"class A : public B, public C\n"

"{\n"

"public:\n"

" char *s;\n"

" A & operator=(const A &a)\n"

" {\n"

" free(s);\n"

" s = strdup(a.s);\n"

" return *this;\n"

" }\n"

"};\n");

ASSERT_EQUALS("", errout.str());

// this test has multiple inheritance so there is no trivial way to test for self assignment but doesn't need it

checkOpertorEqToSelf(

"class A : public B, public C\n"

"{\n"

"public:\n"

" A & operator=(const A &);\n"

"};\n"

"A & A::operator=(const A &a) { return *this; }\n");

ASSERT_EQUALS("", errout.str());

// this test has multiple inheritance and needs an assignment test but there is no trivial way to test for it

checkOpertorEqToSelf(

"class A : public B, public C\n"

"{\n"

"public:\n"

" char *s;\n"

" A & operator=(const A &);\n"

"};\n"

"A & A::operator=(const A &a)\n"

"{\n"

" free(s);\n"

" s = strdup(a.s);\n"

" return *this;\n"

"}\n");

ASSERT_EQUALS("", errout.str());

}

void operatorEqToSelf4()

{

// this test has multiple inheritance so there is no trivial way to test for self assignment but doesn't need it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B : public C, public D\n"

" {\n"

" public:\n"

" B & operator=(const B &b) { return *this; }\n"

" };\n"

"};\n");

ASSERT_EQUALS("", errout.str());

// this test has multiple inheritance and needs an assignment test but there is no trivial way to test for it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B : public C, public D\n"

" {\n"

" public:\n"

" char * s;\n"

" B & operator=(const B &b)\n"

" {\n"

" free(s);\n"

" s = strdup(b.s);\n"

" return *this;\n"

" }\n"

" };\n"

"};\n");

ASSERT_EQUALS("", errout.str());

// this test has multiple inheritance so there is no trivial way to test for self assignment but doesn't need it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B : public C, public D\n"

" {\n"

" public:\n"

" B & operator=(const B &);\n"

" };\n"

"};\n"

"A::B & A::B::operator=(const A::B &b) { return *this; }\n");

ASSERT_EQUALS("", errout.str());

// this test has multiple inheritance and needs an assignment test but there is no trivial way to test for it

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" class B : public C, public D\n"

" {\n"

" public:\n"

" char * s;\n"

" B & operator=(const B &);\n"

" };\n"

"};\n"

"A::B & A::B::operator=(const A::B &b)\n"

"{\n"

" free(s);\n"

" s = strdup(b.s);\n"

" return *this;\n"

"}\n");

ASSERT_EQUALS("", errout.str());

}

void operatorEqToSelf5()

{

// ticket # 1233

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" char *s;\n"

" A & operator=(const A &a)\n"

" {\n"

" if((&a!=this))\n"

" {\n"

" free(s);\n"

" s = strdup(a.s);\n"

" }\n"

" return *this;\n"

" }\n"

"};");

ASSERT_EQUALS("", errout.str());

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" char *s;\n"

" A & operator=(const A &a)\n"

" {\n"

" if((this!=&a))\n"

" {\n"

" free(s);\n"

" s = strdup(a.s);\n"

" }\n"

" return *this;\n"

" }\n"

"};");

ASSERT_EQUALS("", errout.str());

checkOpertorEqToSelf(

"class A\n"

"{\n"

"public:\n"

" char *s;\n"

" A & operator=(const A &a)\n"

" {\n"

" if(!(&a==this))\n"

" {\n"

" free(s);\n"

" s = strdup(a.s);\n"

" }\n"

View remainder of file in raw view

cppcheck/test/testclass.cpp at master · applsdev/cppcheck · GitHub

Navigation Menu

Expand file tree

Breadcrumbs

testclass.cpp

Latest commit

History

Breadcrumbs

testclass.cpp

File metadata and controls

Footer

Footer navigation