| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
The current del module.__warningregistry__ fails with a TypeError rather than AttributeError for h5py. It seems reasonable to just skip trying to delete it on any exception. Tests pass after this change.
|
Failures unrelated - will be fixed by #12390 |
Sorry, something went wrong.
|
Thanks for the fix! As an aside we really should consider deprecating our custom machinery for treating deprecation warnings as exceptions at some point since it is possible to do the same with pytest options... |
Sorry, something went wrong.
…deprecations as exceptions.
…389-on-v5.0.x Backport PR #12389 on branch v5.0.x (Ensure no unexpected failures in treating deprecations as exceptions.)
| Back | FazBrowse Home | New Git URL |
The current del module.__warningregistry__ fails with a TypeError rather than AttributeError for h5py.
It seems reasonable to just skip trying to delete it on any exception. Tests run after this change. I don't really know how to add a test for this, though, short of testing with more Debian packages in our test grid.
Fixes #12388
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.