| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
…on the request in Default mode
…r than the host machine
| -w /development \ | ||
| amazonlinux:2018.03 ./package.sh $DIST_OUTPUT_BUCKET $TEMPLATE_OUTPUT_BUCKET $VERSION | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Added this so I could locally have a repeatable build from a non-amazonlinux distro
Sorry, something went wrong.
|
@shsenior get a chance to look at this yet? Wasn't sure who the other maintainers were. Feedback welcome. |
Sorry, something went wrong.
|
@leviwilson - added for review, thanks for contributing! |
Sorry, something went wrong.
|
Any news on this? |
Sorry, something went wrong.
Nope. @hayesry is there any sort of information to look to see what the process is for getting PRs into awslabs repositories? There is a lot of interest (or so it seems) from the community and to be honest the cadence in which PRs are reviewed (even well after they are added for review) is incredibly long. From the perspective of those that wish to contribute it's discouraging / disincentivizing if that feedback loop is over a quarter of the year. |
Sorry, something went wrong.
|
Thanks for your effort here, @leviwilson You can refer to the recent changes here |
Sorry, something went wrong.
|
@leviwilson would there be a need to be able to provide the options parameter for the toFormat function? https://sharp.pixelplumbing.com/api-output#toformat |
Sorry, something went wrong.
|
@kjanoudi unsure? The need I'd had was simply to specify the output format, so I didn't dig too much into the other optional arguments. |
Sorry, something went wrong.
|
Hi there I'd like to set output options to the PNG outputFormat |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fixes
Description
This PR fixes #116 by allowing the outputFormat to be specified in the JSON request when the requestType: "Default".
This allows for the consumer to control what format the returned image is in according to what is allowable by Sharp#toFormat
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.