FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Honor outputFormat Parameter by leviwilson · Pull Request #117 · aws-solutions/dynamic-image-transformation-for-amazon-cloudfront · GitHub

Honor outputFormat Parameter - #117

Closed
leviwilson wants to merge 5 commits into
aws-solutions:masterfrom
leviwilson:sharp-output-format
Closed

leviwilson wants to merge 5 commits into
aws-solutions:masterfrom
leviwilson:sharp-output-format

Conversation

Copy link
Copy Markdown

Fixes

Description

This PR fixes #116 by allowing the outputFormat to be specified in the JSON request when the requestType: "Default".

This allows for the consumer to control what format the returned image is in according to what is allowable by Sharp#toFormat

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment thread README.md
-w /development \
amazonlinux:2018.03 ./package.sh $DIST_OUTPUT_BUCKET $TEMPLATE_OUTPUT_BUCKET $VERSION
```

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added this so I could locally have a repeatable build from a non-amazonlinux distro

Copy link
Copy Markdown
Author

@shsenior get a chance to look at this yet? Wasn't sure who the other maintainers were.

Feedback welcome.

Copy link
Copy Markdown
Author

@hayesry or anyone else?

hayesry commented Aug 4, 2019

Copy link
Copy Markdown
Member

@leviwilson - added for review, thanks for contributing!

Copy link
Copy Markdown

Any news on this?

Copy link
Copy Markdown
Author

Any news on this?

Nope. @hayesry is there any sort of information to look to see what the process is for getting PRs into awslabs repositories?

There is a lot of interest (or so it seems) from the community and to be honest the cadence in which PRs are reviewed (even well after they are added for review) is incredibly long.

From the perspective of those that wish to contribute it's discouraging / disincentivizing if that feedback loop is over a quarter of the year.

Copy link
Copy Markdown
Contributor

Thanks for your effort here, @leviwilson
We have updated our solution, and your pull request has been merged into our master branch. However, as we've merged many pull requests at this time, the source code might not exactly same as what you've done. In addition, due to our internal process, we've merged source code manually, so please understand how your effort has been merged.

You can refer to the recent changes here

kjanoudi commented Jun 9, 2020

Copy link
Copy Markdown

@leviwilson would there be a need to be able to provide the options parameter for the toFormat function? https://sharp.pixelplumbing.com/api-output#toformat

Copy link
Copy Markdown
Author

@kjanoudi unsure? The need I'd had was simply to specify the output format, so I didn't dig too much into the other optional arguments.

Copy link
Copy Markdown

Hi there I'd like to set output options to the PNG outputFormat

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

outputFormat option not honored

7 participants


Back | FazBrowse Home | New Git URL