fixed a problem that causes a memory leak. We are passing user, pass, · baigk/libhttpserver@e53d066 · GitHub

baigk / libhttpserver Public

forked from etr/libhttpserver

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit e53d066

Browse filesBrowse the repository at this point in the historyBrowse files

rdiazmartin

committed

fixed a problem that causes a memory leak. We are passing user, pass,

and digested_user as char pointers by value which causes the original pointers be always null when they are going to be free in complete_request, now we pass them by reference and everything works fine

1 parent 4cbfc1f commit e53d066
Copy full SHA for e53d066

2 files changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • httpserver
    • webserver.hpp
  • webserver.cpp

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/httpserver/webserver.hpp‎

Copy file name to clipboardExpand all lines: src/httpserver/webserver.hpp

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -328,7 +328,7 @@ class webserver
328	328
329	329	void end_request_construction(MHD_Connection* connection,
330	330	struct details::modded_request* mr, const char* version,
331		- const char* method, char* user, char* pass, char* digested_user
	331	+ const char* method, char* &user, char* &pass, char* &digested_user
332	332	);
333	333
334	334	int finalize_answer(MHD_Connection* connection,

Collapse file

‎src/webserver.cpp‎

Copy file name to clipboardExpand all lines: src/webserver.cpp

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -964,9 +964,9 @@ void webserver::end_request_construction(
964	964	struct details::modded_request* mr,
965	965	const char* version,
966	966	const char* method,
967		- char* user,
968		- char* pass,
969		- char* digested_user
	967	+ char* &user,
	968	+ char* &pass,
	969	+ char* &digested_user
970	970	)
971	971	{
972	972	mr->ws = this;

0 commit comments

Comments

0 (0)