Repository navigation
BCrypt::Engine.hash_secret method is generating unexpected long hash string on Fedora 28 #165
Description
Activity
I have just pushed version 3.1.12.rc1 to RubyGems.org which should solve this problem.
Can someone please confirm that gem install bcrypt --prerelease now works on Fedora 28? If so, I'll push out the final version.
Hi,
i have tested with my application. It failed on 3.1.11 while it works perfectly on 3.1.12.rc1
Using ruby 2.5.1 and rails 5.1.5 on Fedora 28Version 3.1.12 of the bcrypt gem, which should fix this issue, was just pushed to RubyGems.
You should now be able to gem install bcrypt on Fedora with none of the above workarounds.
Thanks, everyone!
Reacted by Yalçın Açıkyıldız- added a commit that references this issue on Sep 9, 2018
- added 3 commits that reference this issue on Jul 3, 2021
I tried to generate a new password with Password.create('test') but it throws BCrypt::Errors::InvalidHash (invalid hash) error. Then i try to generate hash with BCrypt::Engine.hash_secret('secret', BCrypt::Engine.generate_salt(1)) to see what's wrong there and i noticed the code generated 32767 character long string as the following
$2a$04$tk0ZskJEMxKW5Zx0OIMy/Ot5z.Vleg7SXfRV9.GryPpKRchRK/S3m\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\............
Because of unexpected long hash string the valid_hash? method returns nil and broke the app.
I test the problem against to ruby 2.4.1, 2.5.0 and 2.5.1 on Fedora 28. All of them were failing.
I check the GCC version and noticed that it upgraded to 8.x on Fedora 28. I am not sure, but it could be a compiler related bug..