| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
This PR includes implementing this new GitHub action in app-build-verify but it will also need to be implemented in Toga's CI and Python-support-testbed's CI. Once the new beeware/actions repo is running, it'll use this as well. |
Sorry, something went wrong.
|
@rmartin16 I just noticed this PR had slipped through the review cracks. My initial impression is that it makes sense - any recollection why (beyond "analogous changes needed in Toga etc") this was a draft? |
Sorry, something went wrong.
|
This was part of (another one of..) my experiment for creating public-facing GitHub Actions. As part of that, I created the Action in this PR to consolidate this logic for Android. However, then, we had the question of how such public Actions should interact with our "internal" Actions. Internally, we don't do any versioning and just kinda deal with the fallout from that (although, it isn't exactly "free" to introduce versioning...so, pro/con here). With public-facing Actions, we were thinking it might be more prudent to prevent updates to underlying Actions from just taking effect automatically in the public-facing ones. A thought, though, is if Dependabot will bump Git hashes; that is, if the public-facing Actions pin any underlying "internal" Actions with a commit hash, would Dependabot bump them to ensure we test such changes before they are exposed to users. Anyway, that's where this is right now... |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Changes
PR Checklist: