FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

A little wrong place :) · Issue #104 · binaryjs/binaryjs · GitHub

Repository navigation

A little wrong place :) #104

Description

There is a wrong place at line 30 and 31 of binary.js in my opinion.
var wstest = new WebSocket('ws://null');
wstest.onerror = function(){console.log(wstest);};
if (typeof(wstest.binaryType) !== "undefined") {
return true;
} else {
return false;
}
wstest.close();//line 30
wstest = null;//line 31
So,them could'nt be executed forever.
PS:Could you please replace 'ws://null' with 'ws://echo.websocket.org',:)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL