Commit 0a5bd6e
Correctly reference inspect parameter kinds
Instead of referencing parameter kinds as class attributes on the private
`_ParameterKind` class we reference them on the public `Parameter` class. This
has two advantages:
1) We don't use a private interface.
2) The class attributes on `_ParameterKind` have only been added in Python 3.5,
but on `Parameter` they have existed since Python 3.3.1 parent a9407b6 commit 0a5bd6e
1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -304,18 +304,18 @@ def get_argspec_from_signature(f): | |||
| 304 | 304 | if parameter.annotation is not inspect._empty: | |
| 305 | 305 | annotations[parameter.name] = parameter.annotation | |
| 306 | 306 | ||
| 307 | - if parameter.kind == inspect._ParameterKind.POSITIONAL_OR_KEYWORD: | ||
| 307 | + if parameter.kind == inspect.Parameter.POSITIONAL_OR_KEYWORD: | ||
| 308 | 308 | args.append(parameter.name) | |
| 309 | 309 | if parameter.default is not inspect._empty: | |
| 310 | 310 | defaults.append(parameter.default) | |
| 311 | - elif parameter.kind == inspect._ParameterKind.POSITIONAL_ONLY: | ||
| 311 | + elif parameter.kind == inspect.Parameter.POSITIONAL_ONLY: | ||
| 312 | 312 | args.append(parameter.name) | |
| 313 | - elif parameter.kind == inspect._ParameterKind.VAR_POSITIONAL: | ||
| 313 | + elif parameter.kind == inspect.Parameter.VAR_POSITIONAL: | ||
| 314 | 314 | varargs = parameter.name | |
| 315 | - elif parameter.kind == inspect._ParameterKind.KEYWORD_ONLY: | ||
| 315 | + elif parameter.kind == inspect.Parameter.KEYWORD_ONLY: | ||
| 316 | 316 | kwonly.append(parameter.name) | |
| 317 | 317 | kwonly_defaults[parameter.name] = parameter.default | |
| 318 | - elif parameter.kind == inspect._ParameterKind.VAR_KEYWORD: | ||
| 318 | + elif parameter.kind == inspect.Parameter.VAR_KEYWORD: | ||
| 319 | 319 | varkwargs = parameter.name | |
| 320 | 320 | ||
| 321 | 321 | # inspect.getfullargspec returns None for 'defaults', 'kwonly_defaults' and | |
0 commit comments