Commit 8c7bff7
committed
Correct workflow artifact name pattern in size deltas report workflow
The "sketches-reports-source" input of the "arduino/report-size-deltas" GitHub Actions action defines the regular
expression that matches the names of the sketches report workflow artifacts produced by the "Compile Examples" workflow.
The key string in the names of these artifacts was set to "sketches-report" when the "Compile Examples" workflow was
adjusted for compatibility with the breaking changes introduced by updating to version 4.x of the workflow's
"actions/upload-artifact" GitHub Actions action dependency. The pattern set in the size deltas report workflow was
"sketches-reports". The "s" at the end of that pattern caused it to no longer match against the key string in the
artifact names after that adjustment of the "Compile Examples" workflow, resulting in size deltas reports no longer
being generated by the workflow.
Although a minimal fix would be to simply remove the "s" from the end of the pattern, the decision was made to use a
more strict regular expression. This will make it easier for maintainers and contributors to understand that this value
is a regular expression and the exact nature of how that regular expression functions (which is less clear when relying
on the "arduino/report-size-deltas" action's partial pattern matching behavior).1 parent 9f01bfe commit 8c7bff7
2 files changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -20,5 +20,5 @@ jobs: | |||
| 20 | 20 | - name: Comment size deltas reports to PRs | |
| 21 | 21 | uses: arduino/report-size-deltas@v1 | |
| 22 | 22 | with: | |
| 23 | - # The name of the workflow artifact created by the sketch compilation workflow | ||
| 24 | - sketches-reports-source: sketches-reports | ||
| 23 | + # Regex matching the names of the workflow artifacts created by the "Compile Examples" workflow | ||
| 24 | + sketches-reports-source: ^sketches-report-.+ | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,3 +3,4 @@ examples/node_test_server/node_modules/ | |||
| 3 | 3 | *.DS_Store | |
| 4 | 4 | */.DS_Store | |
| 5 | 5 | examples/.DS_Store | |
| 6 | + .idea/ | ||
0 commit comments