Repository navigation
Commit 9d2c977
authored
Use _isFull instead of duplicating clients check (#2539)
Noticed that options.max is compared against client count directly, but there's a method wrapping it. I can't see any reason to duplicate it? And using _isFull means I can override that for the adaptive pooling idea I'm exploring :)1 parent a040031 commit 9d2c977
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -168,7 +168,7 @@ class Pool extends EventEmitter { | |||
| 168 | 168 | const result = response.result | |
| 169 | 169 | ||
| 170 | 170 | // if we don't have to connect a new client, don't do so | |
| 171 | - if (this._clients.length >= this.options.max || this._idle.length) { | ||
| 171 | + if (this._isFull() || this._idle.length) { | ||
| 172 | 172 | // if we have idle clients schedule a pulse immediately | |
| 173 | 173 | if (this._idle.length) { | |
| 174 | 174 | process.nextTick(() => this._pulseQueue()) | |
0 commit comments