Sanitizer: Allow <summary> (#423) · cclauss/html5lib-python@ff7fa37 · GitHub

cclauss / html5lib-python Public

forked from html5lib/html5lib-python

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ff7fa37

Browse filesBrowse the repository at this point in the historyBrowse files

twm

and

ambv

authored

Sanitizer: Allow <summary> (html5lib#423)

Add tests that the sanitizer allows <details open> and <summary> and update the implementation to allow <summary>. Co-authored-by: Łukasz Langa <lukasz@langa.pl>

1 parent c64a111 commit ff7fa37
Copy full SHA for ff7fa37

3 files changed

+20-1Lines changed: 20 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• CHANGES.rst
• html5lib
  • filters
    • sanitizer.py
  • tests
    • test_sanitizer.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎CHANGES.rst‎

Copy file name to clipboardExpand all lines: CHANGES.rst

+7-1Lines changed: 7 additions & 1 deletion

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -1,6 +1,13 @@
1	1	Change Log
2	2	----------
3	3
	4	+ 1.2
	5	+ ~~~
	6	+
	7	+ Bug fixes:
	8	+
	9	+ * The sanitizer now permits ``<summary>`` tags.
	10	+
4	11	1.1
5	12	~~~
6	13
@@ -22,7 +29,6 @@ Other changes:
22	29	``html5lib`` keeps working in future Python versions. (#403)
23	30	* Drop optional ``datrie`` dependency. (#442)
24	31
25		-
26	32	1.0.1
27	33	~~~~~
28	34

Collapse file

‎html5lib/filters/sanitizer.py‎

Copy file name to clipboardExpand all lines: html5lib/filters/sanitizer.py

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -113,6 +113,7 @@
113	113	(namespaces['html'], 'strike'),
114	114	(namespaces['html'], 'strong'),
115	115	(namespaces['html'], 'sub'),
	116	+ (namespaces['html'], 'summary'),
116	117	(namespaces['html'], 'sup'),
117	118	(namespaces['html'], 'table'),
118	119	(namespaces['html'], 'tbody'),

Collapse file

‎html5lib/tests/test_sanitizer.py‎

Copy file name to clipboardExpand all lines: html5lib/tests/test_sanitizer.py

+12Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -111,6 +111,18 @@ def param_sanitizer():
111	111	"""<img src="%s:%s">foo</a>""" % (protocol, rest_of_uri))
112	112
113	113
	114	+ def test_details_open_allowed():
	115	+ sanitized = sanitize_html("<details open>.</details>")
	116	+ expected = '<details open>.</details>'
	117	+ assert expected == sanitized
	118	+
	119	+
	120	+ def test_details_summary_allowed():
	121	+ sanitized = sanitize_html("<details><summary>.</summary><p>...</p></details>")
	122	+ expected = '<details><summary>.</summary><p>...</p></details>'
	123	+ assert expected == sanitized
	124	+
	125	+
114	126	@pytest.mark.parametrize("expected, input",
115	127	(pytest.param(expected, input, id=id)
116	128	for id, expected, input in param_sanitizer()))

0 commit comments

Comments

0 (0)