fix: Timestamp formatting and lakehouse-type connector for trino_offl… · cloud-orbitor/feast@c2ea7e9 · GitHub

1. cloud-orbitor
2. feast

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit c2ea7e9

Browse filesBrowse the repository at this point in the historyBrowse files

soliverr

and

franciscojavierarceo

authored

fix: Timestamp formatting and lakehouse-type connector for trino_offline_store. (feast-dev#5846)

Signed-off-by: Sergey Kryazhevskikh <soliverr@gmail.com> Co-authored-by: Francisco Javier Arceo <arceofrancisco@gmail.com>

1 parent 5482a0e commit c2ea7e9
Copy full SHA for c2ea7e9

2 files changed

+8-2Lines changed: 8 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• sdk/python/feast/infra/offline_stores/contrib/trino_offline_store
  • connectors
    • upload.py
  • trino.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/connectors/upload.py‎

Copy file name to clipboardExpand all lines: sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/connectors/upload.py

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -56,6 +56,7 @@
56	56	"oracle",
57	57	"redshift",
58	58	"memsql",
	59	+ "lakehouse",
59	60	}
60	61
61	62	CREATE_SCHEMA_QUERY_TEMPLATE = """

Collapse file

‎sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py‎

Copy file name to clipboardExpand all lines: sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py

+7-2Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -424,11 +424,16 @@ def pull_all_from_table_or_query(
424	424	)
425	425
426	426	timestamp_filter = get_timestamp_filter_sql(
427		- start_date, end_date, timestamp_field, quote_fields=False
	427	+ start_date,
	428	+ end_date,
	429	+ timestamp_field,
	430	+ quote_fields=False,
	431	+ cast_style="timestamp",
	432	+ date_time_separator=" ",
428	433	)
429	434	query = f"""
430	435	SELECT {field_string}
431		- FROM {from_expression}
	436	+ FROM ( {from_expression} )
432	437	WHERE {timestamp_filter}
433	438	"""
434	439	return TrinoRetrievalJob(

0 commit comments

Comments

0 (0)