feat(test): Add testdata table - #8175
Merged
kodiakhq[bot] merged 3 commits intoFeb 19, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
disq
commented
Feb 17, 2023
Comment thread
plugins/source/test/resources/services/testdata.go
| dataAsMap := make(map[string]any) | ||
| for i, c := range table.Columns { | ||
| if data[i].GetStatus() == schema.Present { | ||
| dataAsMap[c.Name] = data[i].String() |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
data[i].Get() fails with array types (no data is inserted), but .String() seems to work for all.
Sorry, something went wrong.
Copy link
Copy Markdown
This PR has the following changes to source plugin(s) tables:
|
Sorry, something went wrong.
disq
commented
Feb 17, 2023
Comment thread
plugins/source/test/resources/services/testdata.go
| table := testdata.TestSourceTable("test_testdata_table") | ||
| for i, c := range table.Columns { | ||
| if strings.HasPrefix(c.Name, "_cq_") { | ||
| table.Columns[i].Name = "test" + c.Name |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
To reduce complexity, rather than removing the _cq_id and _cq_parent_id columns here I just add 'test' to the names.
Sorry, something went wrong.
disq
commented
Feb 17, 2023
Comment thread
plugins/source/test/resources/services/testdata.go
| if strings.HasPrefix(c.Name, "_cq_") { | ||
| table.Columns[i].Name = "test" + c.Name | ||
| } | ||
| table.Columns[i].CreationOptions = schema.ColumnCreationOptions{} |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This resets any primary key/not null definitions.
Sorry, something went wrong.
candiduslynx
approved these changes
Feb 17, 2023
hermanschaaf
approved these changes
Feb 17, 2023
erezrokah
added a commit
that referenced
this pull request
Feb 19, 2023
<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> #### Summary The script logic started failing with #8175. The easiest solution is to skip the test plugin as it doesn't follow other plugins conventions <!-- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Test locally on your own infrastructure - [ ] Run `go fmt` to format your code 🖊 - [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Update or add tests 🧪 - [ ] Ensure the status checks below are successful ✅ --->
kodiakhq Bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
🤖 I have created a release *beep* *boop* --- ## [1.4.0](plugins-source-test-v1.3.34...plugins-source-test-v1.4.0) (2023-02-21) ### Features * **test:** Add testdata table ([#8175](#8175)) ([9a997fe](9a997fe)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.38.2 ([#8156](#8156)) ([ac2d2d7](ac2d2d7)) * **deps:** Update module golang.org/x/net to v0.7.0 [SECURITY] ([#8176](#8176)) ([fc4cef8](fc4cef8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that each cqtype can be used as source for destination testing/development.