FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bugfix/291 iconborderwidth doesnt work by codebude · Pull Request #351 · Shane32/QRCoder · GitHub

Bugfix/291 iconborderwidth doesnt work - #351

Merged
codebude merged 2 commits into
masterfrom
bugfix/291-iconborderwidth-doesnt-work
Nov 23, 2021
Merged

Bugfix/291 iconborderwidth doesnt work#351
codebude merged 2 commits into
masterfrom
bugfix/291-iconborderwidth-doesnt-work

Conversation

codebude commented Nov 23, 2021
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary
This PR fixes/implements the following bugs:

  • The icon's border wasn't rendered (due to a former code removal, which made the parameter useless)
  • The previous method for border rendering was refactored, to work without Region.Exclude(path) (which earlier led to problems on Linux environments)
  • More testcases were written and existing ones improved

Test plan

Closing issues
Fixes #291

codebude merged commit f10daa1 into master Nov 23, 2021
codebude deleted the bugfix/291-iconborderwidth-doesnt-work branch November 23, 2021 22:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iconBorderWidth Doesn't work

1 participant


Back | FazBrowse Home | New Git URL