| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I discovered the same problem yesterday, thank you for the fix! Also, MS Authenticator does not support unescaped URLs, so that fix is really important. |
Sorry, something went wrong.
|
Thanks for this fix, it addresses issue #375. I suggest also escaping the Label value, since an email address can contain / and ? characters. |
Sorry, something went wrong.
Thanks @tom-156842, done 👍 |
Sorry, something went wrong.
|
@codebude Do you have any update on when this fix will be released? |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
All changes here look good. Generated QR codes scan properly with Google Authenticator. Tests have already been added 👍 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
This PR fixes/implements the following bugs/features:
What existing problem does the pull request solve?**
Currently, if you create an OTP with an issuer that contains a space, for example:
and then call ToString on that oneTimePassword, that will return:
otpauth://totp/Google Google:test@google.com?secret=pwq65q55&issuer=Google%20Google
(note the first "Google Google" is not escaped, like the second one in the issuer parameter)
which then looks like this in Google Authenticator after scanning the resulting QR code:
This PR resolves this issue by correctly escaping both instances of the issuer in the URL, which then appears correctly in Google Authenticator:
otpauth://totp/Google%20Google:test@google.com?secret=pwq65q55&issuer=Google%20Google
Test plan
Test cases have been added.
Closing issues
N/A