Add string optimizations by Shane32 · Pull Request #521 · Shane32/QRCoder · GitHub

This PR prevents PlainTextToBinaryByte from encoding the provided string back and forth to the target encoding multiple times. It also caches the encoder for future use, as it is designed to be a singleton. On the .NET Core 5+ TFMs the encoding uses a stack-allocated byte array, reducing heap allocations and memory requirements.

Add tests for UTF8 with and without BOM.

No changes to logic; produced QR codes should be identical to previously for any input.

Hello @gfoidl , hello @Shane32 - I would like to take this opportunity to say once again that I am very impressed by your suggestions and your discussion. To be honest, your optimizations reach a level that exceeds my knowledge of C#/.NET/JIT. Nevertheless, I think I vaguely understand what you are discussing and I think I have learned a thing or two. Thank you very much for your efforts. I bow my head!

This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [QRCoder](https://github.com/codebude/QRCoder) | `1.4.3` -> `1.6.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/QRCoder/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/QRCoder/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/QRCoder/1.4.3/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/QRCoder/1.4.3/1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>codebude/QRCoder (QRCoder)</summary> ### [`v1.6.0`](https://github.com/codebude/QRCoder/releases/tag/v1.6.0) #### What has changed - \[Enhancement] Huge performance (runtime and memory) optimization in `QrCodeGenerator` (PRs [#509](Shane32/QRCoder#509), [#519](Shane32/QRCoder#519), [#520](Shane32/QRCoder#520), [#521](Shane32/QRCoder#521), [#524](Shane32/QRCoder#524), [#530](Shane32/QRCoder#530), [#532](Shane32/QRCoder#532)) - \[Enhancement] Big performance (runtime and memory) optimization in `BitmapByteQRCode` (PR [#566](Shane32/QRCoder#566)) - \[Enhancement] Added ECC level mismatch detection when using payloads from payload generator (PR [#526](Shane32/QRCoder#526)) - \[Enhancement] Implementation of encoding constraints (EccLevel, EciMode) in SwissQRCode and GiroCode payloads to enforce that the payloads comply with the specifications of the respective standards (PR [#533](Shane32/QRCoder#533)) - \[Enhancement] Added support for trimming (`IsTrimmable` project property) (PR [#539](Shane32/QRCoder#539)) - \[Enhancement] Added XML comments (code documentation) to all public members (PR [#561](Shane32/QRCoder#561)) - \[Enhancement] Added new/third overload to `PngByteQRCode` that accepts colors as System.Drawing.Color (PR [#564](Shane32/QRCoder#564)) - \[Enhancement] Updated the Bitmap header from BITMAPCOREHEADER to BITMAPINFOHEADER in `BitmapByteQRCode` (PR [#565](Shane32/QRCoder#565)) - \[Refactoring] Restructured `QRCodeGenerator` classes into separate files and partially restructured code for better manageability (PRs [#516](Shane32/QRCoder#516), [#528](Shane32/QRCoder#528), [#531](https://github....

Shane32 added 6 commits May 7, 2024 10:37

Add string optimizations

e97301b

Use code page numbers

fa926af

Update

27f29c3

Update comments

e08d6e3

Add comment

cd06130

Add comments

554c527