cppcheck/lib/checkpostfixoperator.cpp at main · cppcheck-opensource/cppcheck · GitHub

History

110 lines (92 loc) · 4.31 KB

Raw

100

101

102

103

104

105

106

107

108

109

110

* Cppcheck - A tool for static C/C++ code analysis

* This program is free software: you can redistribute it and/or modify

* it under the terms of the GNU General Public License as published by

* the Free Software Foundation, either version 3 of the License, or

* (at your option) any later version.

* This program is distributed in the hope that it will be useful,

* but WITHOUT ANY WARRANTY; without even the implied warranty of

* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

* GNU General Public License for more details.

* You should have received a copy of the GNU General Public License

* along with this program. If not, see <http://www.gnu.org/licenses/>.

//---------------------------------------------------------------------------

// You should use ++ and -- as prefix whenever possible as these are more

// efficient than postfix operators

//---------------------------------------------------------------------------

#include "checkpostfixoperator.h"

#include "errortypes.h"

#include "settings.h"

#include "symboldatabase.h"

#include "token.h"

#include "tokenize.h"

#include <vector>

//---------------------------------------------------------------------------

// CWE ids used

static const CWE CWE398(398U); // Indicator of Poor Code Quality

void CheckPostfixOperatorImpl::postfixOperator()

{

if (!mSettings.severity.isEnabled(Severity::performance))

return;

logChecker("CheckPostfixOperator::postfixOperator"); // performance

const SymbolDatabase *symbolDatabase = mTokenizer->getSymbolDatabase();

for (const Scope * scope : symbolDatabase->functionScopes) {

for (const Token* tok = scope->bodyStart->next(); tok != scope->bodyEnd; tok = tok->next()) {

const Variable *var = tok->variable();

if (!var || !Token::Match(tok, "%var% ++|--"))

continue;

const Token* parent = tok->next()->astParent();

if (!parent || parent->str() == ";" || (parent->str() == "," && (!parent->astParent() || parent->astParent()->str() != "("))) {

if (var->isPointer() || var->isArray())

continue;

const Token* typeEndTok = var->typeStartToken();

if (Token::simpleMatch(typeEndTok, "::"))

typeEndTok = typeEndTok->next();

while (Token::Match(typeEndTok, "%name% ::|<")) {

if (typeEndTok->linkAt(1)) {

typeEndTok = typeEndTok->linkAt(1)->next();

if (Token::simpleMatch(typeEndTok, "::"))

typeEndTok = typeEndTok->next();

}

else

typeEndTok = typeEndTok->tokAt(2);

}

if (Token::Match(typeEndTok, "iterator|const_iterator|reverse_iterator|const_reverse_iterator")) {

// the variable is an iterator

postfixOperatorError(tok);

} else if (var->type()) {

// the variable is an instance of class

postfixOperatorError(tok);

}

//---------------------------------------------------------------------------

void CheckPostfixOperatorImpl::postfixOperatorError(const Token *tok)

{

reportError(tok, Severity::performance, "postfixOperator",

"Prefer prefix ++/-- operators for non-primitive types.\n"

"Prefix ++/-- operators should be preferred for non-primitive types. "

"Pre-increment/decrement can be more efficient than "

"post-increment/decrement. Post-increment/decrement usually "

"involves keeping a copy of the previous value around and "

"adds a little extra code.", CWE398, Certainty::normal);

}

void CheckPostfixOperator::runChecks(const Tokenizer &tokenizer, ErrorLogger& errorLogger)

{

if (tokenizer.isC())

return;

CheckPostfixOperatorImpl checkPostfixOperator(&tokenizer, tokenizer.getSettings(), errorLogger);

checkPostfixOperator.postfixOperator();

}

void CheckPostfixOperator::getErrorMessages(ErrorLogger& errorLogger, const Settings &settings) const

{

CheckPostfixOperatorImpl c(nullptr, settings, errorLogger);

c.postfixOperatorError(nullptr);

}

cppcheck/lib/checkpostfixoperator.cpp at main · cppcheck-opensource/cppcheck · GitHub

Uh oh!

Expand file tree

Breadcrumbs

checkpostfixoperator.cpp

Latest commit

History

Breadcrumbs

checkpostfixoperator.cpp

File metadata and controls