Various fixes. Python tests still fail. · darobin/html5lib-python@63e1165 · GitHub

darobin / html5lib-python Public

forked from html5lib/html5lib-python

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 63e1165

Browse filesBrowse the repository at this point in the historyBrowse files

rubys

committed

Various fixes. Python tests still fail.

--HG-- extra : convert_revision : svn%3Aacbfec75-9323-0410-a652-858a13e371e0/trunk%40873

1 parent 082885e commit 63e1165
Copy full SHA for 63e1165

3 files changed

+7-3Lines changed: 7 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src/html5lib/treewalkers
  • _base.py
  • dom.py
• tests
  • test_treewalkers.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/html5lib/treewalkers/_base.py‎

Copy file name to clipboardExpand all lines: src/html5lib/treewalkers/_base.py

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -52,7 +52,8 @@ def comment(self, data):
52	52	return {"type": "Comment", "data": unicode(data)}
53	53
54	54	def doctype(self, name):
55		- return {"type": "Doctype", "name": unicode(name), "data": name.upper() == "HTML"}
	55	+ return {"type": "Doctype", "name": unicode(name),
	56	+ "data": name and name.upper() == "HTML"}
56	57
57	58	def unknown(self, nodeType):
58	59	return self.error(_("Unknown node type: ") + nodeType)

Collapse file

‎src/html5lib/treewalkers/dom.py‎

Copy file name to clipboardExpand all lines: src/html5lib/treewalkers/dom.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -10,7 +10,7 @@
10	10	class TreeWalker(_base.NonRecursiveTreeWalker):
11	11	def getNodeDetails(self, node):
12	12	if node.nodeType == Node.DOCUMENT_TYPE_NODE:
13		- return _base.DOCTYPE, node.nodeName
	13	+ return _base.DOCTYPE, node.nodeName or ''
14	14
15	15	elif node.nodeType in (Node.TEXT_NODE, Node.CDATA_SECTION_NODE):
16	16	return _base.TEXT, node.nodeValue

Collapse file

‎tests/test_treewalkers.py‎

Copy file name to clipboardExpand all lines: tests/test_treewalkers.py

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -181,7 +181,10 @@ def convertTokens(tokens):
181	181	elif type == "Comment":
182	182	output.append("%s<!-- %s -->" % (" "*indent, token["data"]))
183	183	elif type == "Doctype":
184		- output.append("%s<!DOCTYPE %s>" % (" "*indent, token["name"]))
	184	+ if token["name"]:
	185	+ output.append("%s<!DOCTYPE %s>" % (" "*indent, token["name"]))
	186	+ else:
	187	+ output.append("%s<!DOCTYPE>" % " "*indent)
185	188	elif type in ("Characters", "SpaceCharacters"):
186	189	output.append("%s\"%s\"" % (" "*indent, token["data"]))
187	190	else:

0 commit comments

Comments

0 (0)