refactor: still don't know what the hell i'm doing with buffer · dev-tim/Android-RxJava@87c4492 · GitHub

dev-tim / Android-RxJava Public

forked from kaushikgopal/RxJava-Android-Samples

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 87c4492

Browse filesBrowse the repository at this point in the historyBrowse files

Kaushik Gopal

committed

refactor: still don't know what the hell i'm doing with buffer

1 parent 57621fe commit 87c4492
Copy full SHA for 87c4492

1 file changed

+14-6Lines changed: 14 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• app/src/main/java/com/morihacky/android/rxjava
  • BufferDemoFragment.java

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎app/src/main/java/com/morihacky/android/rxjava/BufferDemoFragment.java‎

Copy file name to clipboardExpand all lines: app/src/main/java/com/morihacky/android/rxjava/BufferDemoFragment.java

+14-6Lines changed: 14 additions & 6 deletions

Original file line number	Diff line number	Diff line change
@@ -43,7 +43,7 @@ public class BufferDemoFragment
43	43	@Override
44	44	public void onActivityCreated(@Nullable Bundle savedInstanceState) {
45	45	super.onActivityCreated(savedInstanceState);
46		- _setupLogAdapter();
	46	+ _setupLogger();
47	47
48	48	_bufferedObservable = _getBufferedObservable();
49	49	_observer = _getObserver();
@@ -52,6 +52,9 @@ public void onActivityCreated(@Nullable Bundle savedInstanceState) {
52	52
53	53	@OnClick(R.id.btn_start_operation)
54	54	public void onButtonTapped() {
	55	+ Timber.d("--------- GOT A TAP");
	56	+ _tapCount += 1;
	57	+ _log("GOT A TAP");
55	58	_bufferedObservable.subscribeOn(Schedulers.io())
56	59	.observeOn(AndroidSchedulers.mainThread())
57	60	.subscribe(_observer);
@@ -67,7 +70,6 @@ private Observable<List<Integer>> _getBufferedObservable() {
67	70	@Override
68	71	public void call(Subscriber<? super Integer> subscriber) {
69	72	subscriber.onNext(1);
70		- // send one tap
71	73	}
72	74
73	75	}).buffer(2, TimeUnit.SECONDS);
@@ -91,10 +93,16 @@ public void onError(Throwable e) {
91	93
92	94	@Override
93	95	public void onNext(List<Integer> integers) {
94		- for (int i : integers) {
95		- _tapCount += i;
	96	+ Timber.d("--------- onNext");
	97	+
	98	+ if (integers.size() > 0) {
	99	+ for (int i : integers) {
	100	+ _tapCount += i;
	101	+ }
	102	+ onCompleted();
	103	+ } else {
	104	+ Timber.d("--------- No taps received ");
96	105	}
97		- onCompleted();
98	106	}
99	107	};
100	108	}
@@ -111,7 +119,7 @@ public View onCreateView(LayoutInflater inflater,
111	119	return layout;
112	120	}
113	121
114		- private void _setupLogAdapter() {
	122	+ private void _setupLogger() {
115	123	_logs = new ArrayList<String>();
116	124	_adapter = new LogAdapter(getActivity(), new ArrayList<String>());
117	125	_logsList.setAdapter(_adapter);

0 commit comments

Comments

0 (0)