FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add types to flowconfig · devhttps/frontend@1256d03 · GitHub

/ frontend Public
forked from guardian/frontend

Commit 1256d03

Browse files
Regis Kuckaertz
committed
Add types to flowconfig
1 parent 08076bd commit 1256d03

6 files changed

Lines changed: 58 additions & 17 deletions

File tree

‎.flowconfig‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ ui/src/__flow__/types.js
2020
ui/src/__flow__/preact.js
2121
ui/src/__flow__/emotion.js
2222

23+
####### ATOM LIBRARY #######
24+
node_modules/@guardian/atom-renderer/dist/__flow__/types
25+
2326
[options]
2427
emoji=true
2528

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"yarn": "1.2.1"
1212
},
1313
"dependencies": {
14-
"@guardian/atom-renderer": "0.8.10",
14+
"@guardian/atom-renderer": "0.8.13",
1515
"bean": "~1.0.14",
1616
"bonzo": "~2.0.0",
1717
"circular-dependency-plugin": "3.0.0",

‎static/src/javascripts/bootstraps/enhanced/atoms.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import config from 'lib/config';
44
import { services } from 'projects/atoms/services';
55

6-
const bootstrapAtom = (atomMaker: AtomMaker, atomType: AtomType) => {
6+
const bootstrapAtom = <A>(atomMaker: AtomMaker<A>, atomType: AtomType) => {
77
const atomBuilder = atomMaker[atomType].default(services);
88
[
99
...document.querySelectorAll(`[data-atom-type='${atomType}']`),

‎static/src/javascripts/projects/atoms/services.js‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// @flow
22
import ophan from 'ophan/ng';
3-
import fastdom from 'fastdom';
3+
import fastdom from 'lib/fastdom-promise';
44
import { viewport } from './services/viewport';
55

66
// Need to pass in the API to native services, something that looks
@@ -14,12 +14,8 @@ import { viewport } from './services/viewport';
1414
const services: Services = {
1515
ophan,
1616
dom: {
17-
write: (f: () => void) => {
18-
fastdom.write(f);
19-
},
20-
read: (f: () => void) => {
21-
fastdom.read(f);
22-
},
17+
write: (f: () => void) => fastdom.write(f),
18+
read: <A>(f: () => A) => fastdom.read(f),
2319
},
2420
viewport,
2521
};

‎static/src/javascripts/projects/atoms/services/viewport.js‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const cache: Map<number, ObserverRecord> = new Map();
1010
const observe = (
1111
element: Element,
1212
threshold: number,
13-
callback: () => void
13+
callback: number => void
1414
): void => {
1515
let record = cache.get(threshold);
1616
if (!record) {
@@ -42,7 +42,12 @@ const observe = (
4242
record.observer.observe(element);
4343
};
4444

45-
const unobserve = (element: Element, threshold: number): void => {
45+
const unobserve = (
46+
element: Element,
47+
threshold: number,
48+
// eslint-disable-next-line no-unused-vars
49+
callback: number => void
50+
): void => {
4651
const record = cache.get(threshold);
4752
if (!record) return;
4853

‎yarn.lock‎

Lines changed: 43 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,16 @@
22
# yarn lockfile v1
33

44

5-
"@guardian/atom-renderer@0.8.10":
6-
version "0.8.10"
7-
resolved "https://registry.yarnpkg.com/@guardian/atom-renderer/-/atom-renderer-0.8.10.tgz#700d708fdc42b19d6f23536bb5202b670a5b9b0e"
5+
"@guardian/atom-renderer@0.8.13":
6+
version "0.8.13"
7+
resolved "https://registry.yarnpkg.com/@guardian/atom-renderer/-/atom-renderer-0.8.13.tgz#96cc219836f364a4da947b793c220be82bd973e5"
88
dependencies:
99
autoprefixer "^7.1.6"
1010
css-loader "^0.28.7"
1111
postcss-css-variables "^0.8.0"
1212
postcss-import "^11.0.0"
1313
postcss-loader "^2.0.8"
14+
recursive-copy "^2.0.7"
1415
sass-loader "^6.0.6"
1516
sass-mq "^3.3.2"
1617
style-loader "^0.19.0"
@@ -318,6 +319,10 @@ arr-flatten@^1.0.1:
318319
version "1.0.1"
319320
resolved "https://registry.yarnpkg.com/arr-flatten/-/arr-flatten-1.0.1.tgz#e5ffe54d45e19f32f216e91eb99c8ce892bb604b"
320321

322+
array-differ@^1.0.0:
323+
version "1.0.0"
324+
resolved "https://registry.yarnpkg.com/array-differ/-/array-differ-1.0.0.tgz#eff52e3758249d33be402b8bb8e564bb2b5d4031"
325+
321326
array-equal@^1.0.0:
322327
version "1.0.0"
323328
resolved "https://registry.yarnpkg.com/array-equal/-/array-equal-1.0.0.tgz#8c2a5ef2472fd9ea742b04c77a75093ba2757c93"
@@ -2793,7 +2798,7 @@ defined@^1.0.0:
27932798
version "1.0.0"
27942799
resolved "https://registry.yarnpkg.com/defined/-/defined-1.0.0.tgz#c98d9bcef75674188e110969151199e39b1fa693"
27952800

2796-
del@^2.0.2:
2801+
del@^2.0.2, del@^2.2.0:
27972802
version "2.2.2"
27982803
resolved "https://registry.yarnpkg.com/del/-/del-2.2.2.tgz#c12c981d067846c84bcaf862cff930d907ffd1a8"
27992804
dependencies:
@@ -3033,6 +3038,10 @@ elliptic@^6.0.0:
30333038
minimalistic-assert "^1.0.0"
30343039
minimalistic-crypto-utils "^1.0.0"
30353040

3041+
emitter-mixin@0.0.3:
3042+
version "0.0.3"
3043+
resolved "https://registry.yarnpkg.com/emitter-mixin/-/emitter-mixin-0.0.3.tgz#5948cb286f2e48edc3b251a7cfc1f7883396d65c"
3044+
30363045
emitter-steward@^1.0.0:
30373046
version "1.0.0"
30383047
resolved "https://registry.yarnpkg.com/emitter-steward/-/emitter-steward-1.0.0.tgz#f3411ade9758a7565df848b2da0cbbd1b46cbd64"
@@ -3235,7 +3244,7 @@ err-code@^1.0.0:
32353244
version "1.1.2"
32363245
resolved "https://registry.yarnpkg.com/err-code/-/err-code-1.1.2.tgz#06e0116d3028f6aef4806849eb0ea6a748ae6960"
32373246

3238-
"errno@>=0.1.1 <0.2.0-0", errno@^0.1.3, errno@^0.1.4:
3247+
"errno@>=0.1.1 <0.2.0-0", errno@^0.1.2, errno@^0.1.3, errno@^0.1.4:
32393248
version "0.1.4"
32403249
resolved "https://registry.yarnpkg.com/errno/-/errno-0.1.4.tgz#b896e23a9e5e8ba33871fc996abd3635fc9a1c7d"
32413250
dependencies:
@@ -6025,6 +6034,10 @@ jsx-ast-utils@^2.0.0:
60256034
dependencies:
60266035
array-includes "^3.0.3"
60276036

6037+
junk@^1.0.1:
6038+
version "1.0.3"
6039+
resolved "https://registry.yarnpkg.com/junk/-/junk-1.0.3.tgz#87be63488649cbdca6f53ab39bec9ccd2347f592"
6040+
60286041
karma:
60296042
version "1.3.0"
60306043
resolved "https://registry.yarnpkg.com/karma/-/karma-1.3.0.tgz#b2b94e8f499fadd0069d54f9aef4a4d48ec5cc1f"
@@ -6613,6 +6626,15 @@ mathml-tag-names@^2.0.1:
66136626
version "2.0.1"
66146627
resolved "https://registry.yarnpkg.com/mathml-tag-names/-/mathml-tag-names-2.0.1.tgz#8d41268168bf86d1102b98109e28e531e7a34578"
66156628

6629+
maximatch@^0.1.0:
6630+
version "0.1.0"
6631+
resolved "https://registry.yarnpkg.com/maximatch/-/maximatch-0.1.0.tgz#86cd8d6b04c9f307c05a6b9419906d0360fb13a2"
6632+
dependencies:
6633+
array-differ "^1.0.0"
6634+
array-union "^1.0.1"
6635+
arrify "^1.0.0"
6636+
minimatch "^3.0.0"
6637+
66166638
md5.js@^1.3.4:
66176639
version "1.3.4"
66186640
resolved "https://registry.yarnpkg.com/md5.js/-/md5.js-1.3.4.tgz#e9bdbde94a20a5ac18b04340fc5764d5b09d901d"
@@ -8257,7 +8279,7 @@ promise@7.1.1, promise@^7.0.3:
82578279
dependencies:
82588280
asap "~2.0.3"
82598281

8260-
promise@^7.1.1:
8282+
promise@^7.0.1, promise@^7.1.1:
82618283
version "7.3.1"
82628284
resolved "https://registry.yarnpkg.com/promise/-/promise-7.3.1.tgz#064b72602b18f90f29192b8b1bc418ffd1ebd3bf"
82638285
dependencies:
@@ -8634,6 +8656,21 @@ recast@^0.11.17, recast@^0.11.20:
86348656
private "~0.1.5"
86358657
source-map "~0.5.0"
86368658

8659+
recursive-copy@^2.0.7:
8660+
version "2.0.7"
8661+
resolved "https://registry.yarnpkg.com/recursive-copy/-/recursive-copy-2.0.7.tgz#24db85c7129d8fadee402e5400cfcf0cb60fca3c"
8662+
dependencies:
8663+
del "^2.2.0"
8664+
emitter-mixin "0.0.3"
8665+
errno "^0.1.2"
8666+
graceful-fs "^4.1.4"
8667+
junk "^1.0.1"
8668+
maximatch "^0.1.0"
8669+
mkdirp "^0.5.1"
8670+
pify "^2.3.0"
8671+
promise "^7.0.1"
8672+
slash "^1.0.0"
8673+
86378674
redent@^1.0.0:
86388675
version "1.0.0"
86398676
resolved "https://registry.yarnpkg.com/redent/-/redent-1.0.0.tgz#cf916ab1fd5f1f16dfb20822dd6ec7f730c2afde"

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL