Commit 1e254a7
Lau Skeeter
Merge pull request guardian#20160 from guardian/revert-20129-lg-mobile-sign-in-link
Remove AB test: Show a sign in / register link on mobile browsers6 files changed
Lines changed: 7 additions & 108 deletions
File tree
- common/app
- conf/switches
- static/src
- javascripts/projects/common/modules/experiments
- tests
- stylesheets
- base
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -16,16 +16,6 @@ trait ABTestSwitches { | |||
| 16 | 16 | exposeClientSide = true | |
| 17 | 17 | ) | |
| 18 | 18 | ||
| 19 | - Switch( | ||
| 20 | - ABTests, | ||
| 21 | - "ab-mobile-nav-sign-in", | ||
| 22 | - "This test will show a sign in link in the mobile nav", | ||
| 23 | - owners = Seq(Owner.withGithub("walaura")), | ||
| 24 | - safeState = Off, | ||
| 25 | - sellByDate = new LocalDate(2019, 6, 7), | ||
| 26 | - exposeClientSide = true | ||
| 27 | - ) | ||
| 28 | - | ||
| 29 | 19 | Switch( | |
| 30 | 20 | ABTests, | |
| 31 | 21 | "ab-acquisitions-epic-liveblog", | |
Lines changed: 7 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,33 +3,30 @@ | |||
| 3 | 3 | @import conf.Configuration | |
| 4 | 4 | @import views.support.DropdownMenus.accountDropdownMenu | |
| 5 | 5 | ||
| 6 | - <div class="new-header__user-account-container"> | ||
| 6 | + <div class="new-header__user-account-container hide-until-desktop"> | ||
| 7 | 7 | ||
| 8 | - <a class="top-bar__item hide-until-desktop js-navigation-sign-in js-navigation-sign-in-top-nav" | ||
| 8 | + <a class="top-bar__item hide-until-desktop js-navigation-sign-in" | ||
| 9 | 9 | data-link-name="nav2 : topbar : signin" | |
| 10 | 10 | href="@Configuration.id.url/signin?INTCMP=DOTCOM_NEWHEADER_SIGNIN"> | |
| 11 | - <span class="hide-until-tablet">Sign in / Register</span> | ||
| 12 | - <span class="hide-from-tablet"> | ||
| 13 | - @views.html.fragments.inlineSvg("profile", "icon", isPresentation = true) | ||
| 14 | - <span class="js-navigation-sign-in-top-nav-body"></span> | ||
| 15 | - </span> | ||
| 11 | + | ||
| 12 | + Sign in / Register | ||
| 16 | 13 | </a> | |
| 17 | 14 | ||
| 18 | - <button class="is-hidden dropdown-menu-fallback js-user-account-trigger hide-until-desktop" | ||
| 15 | + <button class="is-hidden dropdown-menu-fallback js-user-account-trigger" | ||
| 19 | 16 | id="my-account-toggle" | |
| 20 | 17 | title="user account toggle" | |
| 21 | 18 | data-link-name="nav2 : topbar: my account" | |
| 22 | 19 | aria-expanded="false" | |
| 23 | 20 | aria-controls="my-account-dropdown"></button> | |
| 24 | 21 | ||
| 25 | - <label class="top-bar__item popup__toggle is-hidden js-navigation-account-actions hide-until-desktop" | ||
| 22 | + <label class="top-bar__item popup__toggle is-hidden js-navigation-account-actions" | ||
| 26 | 23 | for="my-account-toggle" | |
| 27 | 24 | data-link-name="nav2 : topbar: my account"> | |
| 28 | 25 | ||
| 29 | 26 | My account | |
| 30 | 27 | </label> | |
| 31 | 28 | ||
| 32 | - <ul class="dropdown-menu dropdown-menu--light js-user-account-dropdown-menu hide-until-desktop" | ||
| 29 | + <ul class="dropdown-menu dropdown-menu--light js-user-account-dropdown-menu" | ||
| 33 | 30 | id="my-account-dropdown" | |
| 34 | 31 | aria-hidden="true"> | |
| 35 | 32 | ||
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,11 +5,9 @@ import { getTest as getAcquisitionTest } from 'common/modules/experiments/acquis | |||
| 5 | 5 | import { commercialPrebidSafeframe } from 'common/modules/experiments/tests/commercial-prebid-safeframe.js'; | |
| 6 | 6 | import { commercialAdVerification } from 'common/modules/experiments/tests/commercial-ad-verification.js'; | |
| 7 | 7 | import { FootballWeeklyTreatVsContainer } from 'common/modules/experiments/tests/football-weekly-treat-vs-container'; | |
| 8 | - import { mobileNavSignIn } from './tests/mobile-nav-sign-in'; | ||
| 9 | 8 | ||
| 10 | 9 | export const TESTS: $ReadOnlyArray<ABTest> = [ | |
| 11 | 10 | getAcquisitionTest(), | |
| 12 | - mobileNavSignIn, | ||
| 13 | 11 | commercialPrebidSafeframe, | |
| 14 | 12 | commercialAdVerification, | |
| 15 | 13 | FootballWeeklyTreatVsContainer, | |
Lines changed: 0 additions & 61 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -14,12 +14,6 @@ | |||
| 14 | 14 | } | |
| 15 | 15 | } | |
| 16 | 16 | ||
| 17 | - .hide-until-mobile-medium { | ||
| 18 | - @include mq($until: mobileMedium) { | ||
| 19 | - display: none !important; | ||
| 20 | - } | ||
| 21 | - } | ||
| 22 | - | ||
| 23 | 17 | .hide-until-mobile-landscape { | |
| 24 | 18 | @include mq($until: mobileLandscape) { | |
| 25 | 19 | display: none !important; | |
@@ -52,12 +46,6 @@ | |||
| 52 | 46 | ||
| 53 | 47 | // Hide from | |
| 54 | 48 | ||
| 55 | - .hide-from-mobile-medium { | ||
| 56 | - @include mq(mobileMedium) { | ||
| 57 | - display: none !important; | ||
| 58 | - } | ||
| 59 | - } | ||
| 60 | - | ||
| 61 | 49 | .hide-from-mobile-landscape { | |
| 62 | 50 | @include mq(mobileLandscape) { | |
| 63 | 51 | display: none !important; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -23,19 +23,6 @@ | |||
| 23 | 23 | color: $brightness-20; | |
| 24 | 24 | } | |
| 25 | 25 | ||
| 26 | - .inline-icon { | ||
| 27 | - fill: $brightness-7; | ||
| 28 | - display: inline-block; | ||
| 29 | - vertical-align: middle; | ||
| 30 | - /* | ||
| 31 | - this visually aligns the profile icon with the Support circle, | ||
| 32 | - part of ab-mobile-nav-sign-in | ||
| 33 | - */ | ||
| 34 | - &.inline-profile { | ||
| 35 | - margin-left: -4px; | ||
| 36 | - } | ||
| 37 | - } | ||
| 38 | - | ||
| 39 | 26 | @include mq(tablet) { | |
| 40 | 27 | font-size: 14px; | |
| 41 | 28 | } | |
0 commit comments