Fixes on exports, and put the fallback in the right place · devhttps/frontend@2fea824 · GitHub

devhttps / frontend Public

forked from guardian/frontend

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 2fea824

Browse filesBrowse the repository at this point in the historyBrowse files

katebee

committed

Fixes on exports, and put the fallback in the right place

1 parent a523838 commit 2fea824
Copy full SHA for 2fea824

3 files changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• common/app/conf/switches
  • CommercialSwitches.scala
• static/src/javascripts/projects/commercial/modules/prebid
  • bid-config.js
  • prebid.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎common/app/conf/switches/CommercialSwitches.scala‎

Copy file name to clipboardExpand all lines: common/app/conf/switches/CommercialSwitches.scala

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -352,7 +352,7 @@ trait CommercialSwitches {
352	352	name = "prebid-appnexus",
353	353	description = "Include AppNexus adapter in Prebid auctions",
354	354	owners = group(Commercial),
355		- safeState = On,
	355	+ safeState = Off,
356	356	sellByDate = never,
357	357	exposeClientSide = true
358	358	)

Collapse file

‎static/src/javascripts/projects/commercial/modules/prebid/bid-config.js‎

Copy file name to clipboardExpand all lines: static/src/javascripts/projects/commercial/modules/prebid/bid-config.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -107,8 +107,8 @@ const getIndexSiteId = (): string => {
107	107	}
108	108	} else {
109	109	const site = config
110		- .get('page.pbIndexSites')
111		- .find(s => s.bp === getBreakpointKey(), []);
	110	+ .get('page.pbIndexSites', [])
	111	+ .find(s => s.bp === getBreakpointKey());
112	112	return site && site.id ? site.id.toString() : '';
113	113	}
114	114	};

Collapse file

‎static/src/javascripts/projects/commercial/modules/prebid/prebid.js‎

Copy file name to clipboardExpand all lines: static/src/javascripts/projects/commercial/modules/prebid/prebid.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -68,7 +68,7 @@ class PrebidAdUnit {
68	68	}
69	69	}
70	70
71		- export class PrebidService {
	71	+ class PrebidService {
72	72	static initialise(): void {
73	73	const pbjsConfig = Object.assign(
74	74	{},

0 commit comments

Comments

0 (0)