FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add sign in link · devhttps/frontend@4197313 · GitHub

Commit 4197313

Browse files
Laura
committed
add sign in link
1 parent fec5d10 commit 4197313

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

‎static/src/javascripts/bootstraps/enhanced/common.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { init as initCookieRefresh } from 'common/modules/identity/cookierefresh
1919
import { initNavigation } from 'common/modules/navigation/navigation';
2020
import { Profile } from 'common/modules/navigation/profile';
2121
import { Search } from 'common/modules/navigation/search';
22-
import {emailSignInBanner} from 'common/modules/identity/email-sign-in-banner';
22+
import { emailSignInBanner } from 'common/modules/identity/email-sign-in-banner';
2323
import {
2424
initMembership,
2525
membershipBanner,

‎static/src/javascripts/projects/common/modules/identity/email-sign-in-banner.js‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,17 @@
11
// @flow
22

3-
import fastdom from 'lib/fastdom-promise';
43
import { Message, hasUserAcknowledgedBanner } from 'common/modules/ui/message';
54
import config from 'lib/config';
65
import type { Banner } from 'common/modules/ui/bannerPicker';
76

87
const messageCode: string = 'email-sign-in-banner';
98

10-
const signInLink = `${config.get('page.idUrl')}/login?returnUrl=https://theguardian.com/email-newsletters`;
9+
const signInLink = `${config.get(
10+
'page.idUrl'
11+
)}/login?returnUrl=https://theguardian.com/email-newsletters`;
1112

12-
const isInExperiment = ():boolean => config.get('switches.idEmailSignInUpsell');
13+
const isInExperiment = (): boolean =>
14+
config.get('switches.idEmailSignInUpsell');
1315

1416
const canShow: () => Promise<boolean> = () =>
1517
Promise.resolve(
@@ -24,7 +26,7 @@ const show: () => void = () => {
2426
siteMessageComponentName: messageCode,
2527
});
2628
message.show(
27-
`Enjoying this newsletter? Sign in to get more.`
29+
`Enjoying this newsletter? <a href="${signInLink}">Sign in</a> to get more.`
2830
);
2931
};
3032

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL