Commit 473bf20
Bit of cleanup
1 parent 6f09d71 commit 473bf20
3 files changed
Lines changed: 8 additions & 3 deletions
File tree
- admin/app/dfp
- common/app/common/dfp
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -17,7 +17,7 @@ private[dfp] object ApiHelper extends Logging { | |||
| 17 | 17 | } | |
| 18 | 18 | } | |
| 19 | 19 | ||
| 20 | - dfpLineItem.getRoadblockingType == RoadblockingType.CREATIVE_SET && | ||
| 20 | + ( dfpLineItem.getRoadblockingType == RoadblockingType.CREATIVE_SET ) && | ||
| 21 | 21 | hasA1x1Pixel(dfpLineItem.getCreativePlaceholders) | |
| 22 | 22 | } | |
| 23 | 23 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,7 +7,7 @@ case class DfpDataExtractor( | |||
| 7 | 7 | lineItems: Seq[GuLineItem], | |
| 8 | 8 | invalidLineItems: Seq[GuLineItem]) { | |
| 9 | 9 | ||
| 10 | - val hasValidLineItems = lineItems.nonEmpty | ||
| 10 | + val hasValidLineItems: Boolean = lineItems.nonEmpty | ||
| 11 | 11 | ||
| 12 | 12 | val inlineMerchandisingTargetedTags: InlineMerchandisingTagSet = { | |
| 13 | 13 | lineItems.foldLeft(InlineMerchandisingTagSet()) { (soFar, lineItem) => | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,12 +3,17 @@ package common.dfp | |||
| 3 | 3 | import common.{Edition, Logging} | |
| 4 | 4 | import play.api.libs.json._ | |
| 5 | 5 | ||
| 6 | + /** A PageSkinSponsorship | ||
| 7 | + * is a special decoration of a DFP LineItem that we need to scan for ourselves, | ||
| 8 | + * because DFP doesn't have this concept. | ||
| 9 | + */ | ||
| 6 | 10 | case class PageSkinSponsorship(lineItemName: String, | |
| 7 | 11 | lineItemId: Long, | |
| 8 | 12 | adUnits: Seq[String], | |
| 13 | + // Targeting properties | ||
| 9 | 14 | editions: Seq[Edition], | |
| 10 | 15 | countries: Seq[String], | |
| 11 | - isR2Only: Boolean, | ||
| 16 | + isR2Only: Boolean, // Legacy platform. | ||
| 12 | 17 | targetsAdTest: Boolean, | |
| 13 | 18 | adTestValue: Option[String], | |
| 14 | 19 | keywords: Seq[String]) | |
0 commit comments