auto install deps when running make tasks that need them · devhttps/frontend@5842b7c · GitHub

devhttps / frontend Public

forked from guardian/frontend

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 5842b7c

Browse filesBrowse the repository at this point in the historyBrowse files

sndrs

committed

auto install deps when running make tasks that need them

1 parent 64ad84b commit 5842b7c
Copy full SHA for 5842b7c

3 files changed

+16-31Lines changed: 16 additions & 31 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git-hooks
  • post-merge
• makefile
• tools
  • messages.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git-hooks/post-merge‎

Copy file name to clipboardExpand all lines: git-hooks/post-merge

-8Lines changed: 0 additions & 8 deletions

This file was deleted.

Collapse file

‎makefile‎

Copy file name to clipboardExpand all lines: makefile

+16-16Lines changed: 16 additions & 16 deletions

Original file line number	Diff line number	Diff line change
@@ -50,61 +50,61 @@ watch: compile-dev
50	50	# *********************** ASSETS ***********************
51	51
52	52	# Compile all assets for production.
53		- compile: check-node
	53	+ compile: install
54	54	@./tools/run-task compile
55	55
56	56	# Compile all assets for development.
57		- compile-dev: check-node
	57	+ compile-dev: install
58	58	@./tools/run-task compile --dev
59	59
60		- compile-javascript: check-node # PRIVATE
	60	+ compile-javascript: install # PRIVATE
61	61	@./tools/run-task compile/javascript
62	62
63		- compile-javascript-dev: check-node # PRIVATE
	63	+ compile-javascript-dev: install # PRIVATE
64	64	@./tools/run-task compile/javascript --dev
65	65
66		- compile-css: check-node # PRIVATE
	66	+ compile-css: install # PRIVATE
67	67	@./tools/run-task compile/css
68	68
69		- compile-images: check-node # PRIVATE
	69	+ compile-images: install # PRIVATE
70	70	@./tools/run-task compile/images
71	71
72		- compile-svgs: check-node # PRIVATE
	72	+ compile-svgs: install # PRIVATE
73	73	@./tools/run-task compile/inline-svgs
74	74
75		- compile-fonts: check-node # PRIVATE
	75	+ compile-fonts: install # PRIVATE
76	76	@./tools/run-task compile/fonts
77	77
78		- atomise-css: check-node # PRIVATE
	78	+ atomise-css: install # PRIVATE
79	79	@node tools/atomise-css
80	80
81	81	# * Not ready for primetime use yet... *
82		- pasteup: check-node # PRIVATE
	82	+ pasteup: install # PRIVATE
83	83	@cd static/src/stylesheets/pasteup && npm --silent i && node publish.js
84	84
85	85
86	86
87	87	# *********************** CHECKS ***********************
88	88
89	89	# Run the JS test suite.
90		- test: check-node
	90	+ test: install
91	91	@./tools/run-task test/javascript
92	92
93	93	# Check the JS test suite coverage.
94		- coverage: check-node
	94	+ coverage: install
95	95	@./tools/run-task test/javascript/coverage --stdout
96	96
97	97	# Lint all assets.
98		- validate: check-node
	98	+ validate: install
99	99	@./tools/run-task lint
100	100
101	101	# Lint all SCSS.
102		- validate-sass: check-node # PRIVATE
	102	+ validate-sass: install # PRIVATE
103	103	@./tools/run-task lint/sass
104	104
105	105	# Lint all JS.
106		- validate-javascript: check-node # PRIVATE
	106	+ validate-javascript: install # PRIVATE
107	107	@./tools/run-task lint/javascript
108	108
109		- validate-amp: check-node # PRIVATE
	109	+ validate-amp: install # PRIVATE
110	110	@cd tools/amp-validation && npm install && NODE_ENV=dev node index.js

Collapse file

‎tools/messages.js‎

Copy file name to clipboardExpand all lines: tools/messages.js

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -77,19 +77,12 @@ switch (process.argv[2]) {
77	77	}, 'error');
78	78	break;
79	79
80		- case 'dependency-update':
81		- notify('Run `make install`.', {
82		- heading: 'Dependencies have changed'
83		- }, 'warn');
84		- break;
85		-
86	80	case 'pasteup':
87	81	notify('You will need to release a new version of pasteup to NPM once you’ve merged this branch to master.\n\nTo begin a new release, run `make pasteup`.', {
88	82	heading: 'Pasteup files have changed'
89	83	}, 'info');
90	84	break;
91	85
92		-
93	86	case 'install-steps':
94	87	notify('Please run the following to complete your installation:', {
95	88	heading: 'Additional steps'

0 commit comments

Comments

0 (0)