Use spread filter and forEach instead of doing it old-school longhand :) · devhttps/frontend@9e02ee3 · GitHub

devhttps / frontend Public

forked from guardian/frontend

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 9e02ee3

Browse filesBrowse the repository at this point in the historyBrowse files

JustinPinner

committed

Use spread filter and forEach instead of doing it old-school longhand :)

1 parent 59fdcad commit 9e02ee3
Copy full SHA for 9e02ee3

1 file changed

+3-10Lines changed: 3 additions & 10 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• static/src/javascripts/projects/common/modules/article
  • rich-links.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎static/src/javascripts/projects/common/modules/article/rich-links.js‎

Copy file name to clipboardExpand all lines: static/src/javascripts/projects/common/modules/article/rich-links.js

+3-10Lines changed: 3 additions & 10 deletions

Original file line number	Diff line number	Diff line change
@@ -25,16 +25,9 @@ const hideIfPaidForAndAdFree = (el: Element): Promise<void> => {
25	25	return Promise.resolve();
26	26	}
27	27	return fastdom.write(() => {
28		- for (let child = 0; child < el.children.length; child += 1) {
29		- if (
30		- el.children[child].classList
31		- .toString()
32		- .includes('rich-link--paidfor')
33		- ) {
34		- el.classList.add('u-h');
35		- break;
36		- }
37		- }
	28	+ [...el.children]
	29	+ .filter(child => child.classList.toString().includes('rich-link--paidfor'))
	30	+ .forEach(child => child.classList.add('u-h'));
38	31	});
39	32	};
40	33

0 commit comments

Comments

0 (0)