Listen, Linter, you better hope I never meet you in a dark alley · devhttps/frontend@ba01e9c · GitHub

devhttps / frontend Public

forked from guardian/frontend

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit ba01e9c

Browse filesBrowse the repository at this point in the historyBrowse files

JustinPinner

committed

Listen, Linter, you better hope I never meet you in a dark alley

1 parent 035179b commit ba01e9c
Copy full SHA for ba01e9c

2 files changed

+10-8Lines changed: 10 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• static/src/javascripts/projects/commercial/modules
  • ad-free-slot-remove.js
  • creatives
    • page-skin.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎static/src/javascripts/projects/commercial/modules/ad-free-slot-remove.js‎

Copy file name to clipboardExpand all lines: static/src/javascripts/projects/commercial/modules/ad-free-slot-remove.js

+5-7Lines changed: 5 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -42,14 +42,12 @@ const adFreeSlotRemove = once(
42	42	return fastdom.write(() => {
43	43	if (bodyEl) {
44	44	if (bodyEl.classList.toString().includes('has-page-skin')) {
45		- bodyEl.classList.remove(
46		- 'has-page-skin'
47		- );
	45	+ bodyEl.classList.remove('has-page-skin');
48	46	}
49		- if (bodyEl.classList.toString().includes('has-active-pageskin')) {
50		- bodyEl.classList.remove(
51		- 'has-active-pageskin'
52		- );
	47	+ if (
	48	+ bodyEl.classList.toString().includes('has-active-pageskin')
	49	+ ) {
	50	+ bodyEl.classList.remove('has-active-pageskin');
53	51	}
54	52	}
55	53	adSlotsToRemove.forEach((adSlot: Element) => adSlot.remove());

Collapse file

‎static/src/javascripts/projects/commercial/modules/creatives/page-skin.js‎

Copy file name to clipboardExpand all lines: static/src/javascripts/projects/commercial/modules/creatives/page-skin.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -21,7 +21,11 @@ const pageSkin = (): void => {
21	21	};
22	22
23	23	const togglePageSkin = (): void => {
24		- if (hasPageSkin && hasCrossedBreakpoint(true) && !commercialFeatures.adFree) {
	24	+ if (
	25	+ hasPageSkin &&
	26	+ hasCrossedBreakpoint(true) &&
	27	+ !commercialFeatures.adFree
	28	+ ) {
25	29	togglePageSkinActiveClass();
26	30	}
27	31	};

0 commit comments

Comments

0 (0)