Commit 029cec2
committed
Several changes to mediator.py
1) Fixed several methods whose parameters were not being used (setTm in
TC, Reporter, and DB), and places where class members were being
assigned the value of global variables.
2) Moved an import to the top of the file, as suggested in pep8
(http://www.python.org/dev/peps/pep-0008/#imports).
3) Removed an unused local variable in TestManager's publishReport
method.1 parent da97203 commit 029cec2
1 file changed
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,11 +1,12 @@ | |||
| 1 | 1 | """http://dpip.testingperspective.com/?p=28""" | |
| 2 | 2 | ||
| 3 | + import random | ||
| 3 | 4 | import time | |
| 4 | 5 | ||
| 5 | 6 | ||
| 6 | 7 | class TC: | |
| 7 | 8 | def __init__(self): | |
| 8 | - self._tm = tm | ||
| 9 | + self._tm = None | ||
| 9 | 10 | self._bProblem = 0 | |
| 10 | 11 | ||
| 11 | 12 | def setup(self): | |
@@ -28,7 +29,7 @@ def tearDown(self): | |||
| 28 | 29 | else: | |
| 29 | 30 | print("Test not executed. No tear down required.") | |
| 30 | 31 | ||
| 31 | - def setTM(self, TM): | ||
| 32 | + def setTM(self, tm): | ||
| 32 | 33 | self._tm = tm | |
| 33 | 34 | ||
| 34 | 35 | def setProblem(self, value): | |
@@ -47,7 +48,7 @@ def report(self): | |||
| 47 | 48 | print("Reporting the results of Test") | |
| 48 | 49 | time.sleep(1) | |
| 49 | 50 | ||
| 50 | - def setTM(self, TM): | ||
| 51 | + def setTM(self, tm): | ||
| 51 | 52 | self._tm = tm | |
| 52 | 53 | ||
| 53 | 54 | ||
@@ -67,7 +68,7 @@ def update(self): | |||
| 67 | 68 | print("Updating the test results in Database") | |
| 68 | 69 | time.sleep(1) | |
| 69 | 70 | ||
| 70 | - def setTM(self, TM): | ||
| 71 | + def setTM(self, tm): | ||
| 71 | 72 | self._tm = tm | |
| 72 | 73 | ||
| 73 | 74 | ||
@@ -91,7 +92,7 @@ def setDB(self, db): | |||
| 91 | 92 | ||
| 92 | 93 | def publishReport(self): | |
| 93 | 94 | self._db.update() | |
| 94 | - rvalue = self._reporter.report() | ||
| 95 | + self._reporter.report() | ||
| 95 | 96 | ||
| 96 | 97 | def setTC(self, tc): | |
| 97 | 98 | self._tc = tc | |
0 commit comments