GH-142234: Allow `--enable-wasm-dynamic-linking` under WASI (GH-142235) · dicej/cpython@9e28916 · GitHub

1. dicej
2. cpython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 9e28916

Browse filesBrowse the repository at this point in the historyBrowse files

brettcannon

authored and

dicej

committed

pythonGH-142234: Allow --enable-wasm-dynamic-linking under WASI (pythonGH-142235)

While CPython doesn't support `--enable-wasm-dynamic-linking`, external tools like componentize-py do and they have to patch around it. Since the flag is off by default, allowing the flag so external users can add/inject dynamic linking support seems acceptable.

1 parent c8cd731 commit 9e28916
Copy full SHA for 9e28916

3 files changed

+8-4Lines changed: 8 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Misc/NEWS.d/next/Build
  • 2025-12-03-10-44-42.gh-issue-142234.i1kaFb.rst
• configure.ac
• configure

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Misc/NEWS.d/next/Build/2025-12-03-10-44-42.gh-issue-142234.i1kaFb.rst‎

Copy file name to clipboard

+3Lines changed: 3 additions & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,3 @@
	1	+ Allow ``--enable-wasm-dynamic-linking`` for WASI. While CPython doesn't
	2	+ directly support it so external/downstream users do not have to patch in
	3	+ support for the flag.

Collapse file

‎configure‎

Copy file name to clipboardExpand all lines: configure

+3-2Lines changed: 3 additions & 2 deletions

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Collapse file

‎configure.ac‎

Copy file name to clipboardExpand all lines: configure.ac

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1306,11 +1306,11 @@ dnl See https://emscripten.org/docs/compiling/Dynamic-Linking.html
1306	1306	AC_MSG_CHECKING([for --enable-wasm-dynamic-linking])
1307	1307	AC_ARG_ENABLE([wasm-dynamic-linking],
1308	1308	[AS_HELP_STRING([--enable-wasm-dynamic-linking],
1309		- [Enable dynamic linking support for WebAssembly (default is no)])],
	1309	+ [Enable dynamic linking support for WebAssembly (default is no); WASI requires an external dynamic loader to handle imports])],
1310	1310	[
1311	1311	AS_CASE([$ac_sys_system],
1312	1312	[Emscripten], [],
1313		- [WASI], [AC_MSG_ERROR([WASI dynamic linking is not implemented yet.])],
	1313	+ [WASI], [],
1314	1314	[AC_MSG_ERROR([--enable-wasm-dynamic-linking only applies to Emscripten and WASI])]
1315	1315	)
1316	1316	], [

0 commit comments

Comments

0 (0)