| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,7 +1,8 @@ | |||
| 1 | 1 | # Task layer: one registration pattern, one coercion, shared image ops (#692) | |
| 2 | 2 | ||
| 3 | 3 | Written by model `claude-opus-5-5` via provider `anthropic`, at close-out | |
| 4 | - 2026-10-08, from plan v2 on #692 and the stage threads (#773, #774, #775). | ||
| 4 | + 2026-10-08, from plan v2 on #692 and the stage threads (#773, #774, #775, | ||
| 5 | + and fix-forward #785). | ||
| 5 | 6 | Plan v1 approved by Don 2026-10-08 with every default (D1–D3), recorded as | |
| 6 | 7 | v2 with no scope change. Built and verified on mini-ai (mps) the same day. | |
| 7 | 8 | ||
@@ -119,13 +120,30 @@ alternative and also removes the hand-kept tables. | |||
| 119 | 120 | image-task loader `task._load_media` sets. Pipeline inputs still load as | |
| 120 | 121 | RGB. | |
| 121 | 122 | ||
| 123 | + ### Stage D (#785, fix-forward): float-string window counts | ||
| 124 | + | ||
| 125 | + - The feature's final check failed on C-F354h: `join_windows`' validate-time | ||
| 126 | + window-count check (`dw/window_count_errors.py`) skipped `num_frames` / | ||
| 127 | + `overlap` given as numeric-string literals (`"33.0"`). Validate passed a | ||
| 128 | + window list the run then refused at the join step, after the window steps | ||
| 129 | + had already spent their time. That broke stage B's rule that validate and | ||
| 130 | + run agree. | ||
| 131 | + - A build miss, not a plan gap: the plan scoped *variable* coercion in | ||
| 132 | + `window_count_errors.py` out (#338), but the literal task arguments it | ||
| 133 | + reads are task coercion and should have gone through stage B's helper. | ||
| 134 | + `_literal_whole` now reads through `task_domains.whole_number`, the run's | ||
| 135 | + rule (`fb7324d0`, merged `926f96bf`). Tests in | ||
| 136 | + `tests/test_window_count_errors.py`. | ||
| 137 | + - Architecture review passed; verified on mini-ai (mps) with no bounces. | ||
| 138 | + | ||
| 122 | 139 | ## Bounces | |
| 123 | 140 | ||
| 124 | 141 | | Stage | Bounces | What | | |
| 125 | 142 | |---|---|---| | |
| 126 | 143 | | A (#773) | 1 tester | SE-F045: `restore_to_source.fit` and `paste_face_track.track` weren't declared as media arguments, so a `../` or `/etc/hosts` record path validated. The fix declared them, added them to `LOCAL_ONLY_TASK_ARGUMENTS`, and a sweep found and declared `paste_face_track.clip`/`.repaired`, `crop_face_track.clip` and `stabilize_video.clip`. This was exactly the silent-drop class the feature set out to close. The old hand-kept table had missed them too. | | |
| 127 | 144 | | B (#774) | 1 tester | C-F356: `grade.exposure` had no domain, so validate let `"0.5"`/`true`/`"nan"` through and the handler raised `TypeError`. Fixed with the `finite` domain and coercion at dispatch. | | |
| 128 | 145 | | C (#775) | 1 architecture review, 1 tester | Review: `padding_to_grid` did grid arithmetic that `variable_constraints.aligned` owns, and the map lacked rows for `image_ops` and `load_json_record`. Tester, C-F361: an RGBA file read from `asset:`/`output:` came back opaque because `load_image` flattened it to RGB before the command ran. The flattening predates the stage, but the stage's acceptance needed it fixed. | | |
| 146 | + | Feature final check | 1 tester | C-F354h: float-string `num_frames`/`overlap` silenced `join_windows`' validate-time count check. Fixed forward in stage D (#785), which passed review and verify first time. | | ||
| 129 | 147 | ||
| 130 | 148 | Cost per stage is not recorded: the stage comments name no `usage:` figures. | |
| 131 | 149 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -58,7 +58,7 @@ remaining deferred fix is recorded in | |||
| 58 | 58 | deferred (`hold_audio` and refine terms, calibration margins, with their | |
| 59 | 59 | triggers): `complete/h3-guide-vram-complete.md`. | |
| 60 | 60 | - **Task layer consolidation: one registration pattern, one coercion, | |
| 61 | - shared image ops** (#692, stages #773-#775), shipped 2026-10-08. A task's | ||
| 61 | + shared image ops** (#692, stages #773-#775, fix-forward #785), shipped 2026-10-08. A task's | ||
| 62 | 62 | domains, choices, static check and media arguments are declared on | |
| 63 | 63 | `register_command`, and the old tables are derived views. Task numbers | |
| 64 | 64 | are coerced by `whole_number`/`real_number`, and validate and run agree. | |
| Back | FazBrowse Home | New Git URL |
0 commit comments