Activity

1. niloc132 commented on Feb 2, 2024

   

   niloc132

   on Feb 2, 2024

   Contributor

   More actions

   Just ran into this via https://github.com/bmuschko/gradle-docker-plugin, also using pip. My proposed solution was going to be to tweak onNext to null out this.imageId when an error is received. It could make sense to not parse until the stream was finished, but since BuildImageResultCallback.getImageId is private and can't be called until the POST /build is completed, it might be just as simple to check for a error before checking for the imageId.

   docker-java/docker-java-api/src/main/java/com/github/dockerjava/api/command/BuildImageResultCallback.java

   Lines 69 to 79 in 1bac81f

   	private String getImageId() {
   	if (imageId != null) {
   	return imageId;
   	}
   	if (error == null) {
   	throw new DockerClientException("Could not build image");
   	}
   	throw new DockerClientException("Could not build image: " + error);
   	}

   could instead be

    private String getImageId() { 
        if (error != null) { 
            throw new DockerClientException("Could not build image: " + error); 
        } 
     
        if (imageId != null) { 
            return imageId; 
        } 
     
       throw new DockerClientException("Could not build image"); 
    } 
2. niloc132

   added a commit that references this issue on Feb 2, 2024

   If BuildImage fails but logs something about success, don't succeed

   This issue will close once commit 8fad77c is merged into the 'main' branch.

   8fad77c
3. eddumelendez

   closed this as completedin #2305on Feb 26, 2024
4. eddumelendez

   added a commit that references this issue on Feb 26, 2024

   If BuildImage fails but logs something about success, don't succeed (#…

   This issue will close once commit 4d8c436 is merged into the 'main' branch.

   4d8c436