Repository navigation
fix: auto header config heading generate func - #2474
Merged
Koooooo-7 merged 2 commits intoJul 28, 2024
Merged
Koooooo-7 merged 2 commits into
Koooooo-7 merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sorry, something went wrong.
jhildenbiddle
previously approved these changes
Jul 25, 2024
jhildenbiddle
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice work. Looks good with one minor nitpick (removing commented lines in sidebar.test.js).
Sorry, something went wrong.
Comment thread
test/e2e/sidebar.test.js
Outdated
Merged
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For docsify autoHeader config, there is a separately call to renderer of marked.
Fix the autoHeader's heading marked adaption function and add test case for this.
Related issue, if any:
What kind of change does this PR introduce?
Bugfix
For any code change,
Does this PR introduce a breaking change?
Yes
No
Tested in the following browsers: