Repository navigation
fix: handle hash navigation to prevent duplicate callbacks - #2575
Merged
sy-records merged 1 commit intoJul 24, 2025
Merged
sy-records merged 1 commit into
sy-records merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sorry, something went wrong.
Koooooo-7
reviewed
Jul 23, 2025
Comment thread
src/core/router/history/hash.js
Outdated
Koooooo-7
approved these changes
Jul 23, 2025
Koooooo-7
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Other class/elements which we don't wanna trigger the action in future, we could add them later.
Sorry, something went wrong.
paulhibbitts
self-requested a review
July 23, 2025 14:29
paulhibbitts
approved these changes
Jul 23, 2025
paulhibbitts
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
From a UX perspective I tested the following and the page scrolled to the expected area:
- Visit the Themes section on the PR Preview site
- Click any section link (Ex: Classes)
- Scroll the page
- Click the same section link
Great to see this long-standing issue fixed🎉
Sorry, something went wrong.
This was referenced Jul 25, 2025
This was referenced Jul 25, 2025
Closed
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves hash navigation handling by correctly setting the navigating flag even when the clicked link points to the current hash.
Related issue, if any:
Close #522
What kind of change does this PR introduce?
Bugfix
For any code change,
Does this PR introduce a breaking change?
No
Tested in the following browsers: