FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Should we dispose Timer in ControlScheduler? · Issue #2272 · dotnet/reactive · GitHub

Repository navigation

Should we dispose Timer in ControlScheduler? #2272

Description

GitHub Copilot reviewed #2268 and pointed out that we apparently do not Dispose the Timer objects we create.

Since this wasn't actually new code—this has been in Rx for years, and has simply moved in this PR—that PR did not seem the right place to address this.

On the face of it, Copilot seems to be correct, but the code handling teardown is complex due to multithreading issues, so it needs a closer look.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL