| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,14 +6,6 @@ X https://github.com/processing/processing/issues/3685 | |||
| 6 | 6 | X setFill() on PShape in Java2D throws ArrayIndexOutOfBoundsException | |
| 7 | 7 | X https://github.com/processing/processing/issues/3677 | |
| 8 | 8 | ||
| 9 | - cleaning | ||
| 10 | - X How do images behave when pixelDensity(2) is set? | ||
| 11 | - X https://github.com/processing/processing/issues/3364 | ||
| 12 | - X retina sketches slow to start | ||
| 13 | - X https://github.com/processing/processing/issues/2357 | ||
| 14 | - X zero alpha values still a problem with retina renderer | ||
| 15 | - X https://github.com/processing/processing/issues/2030 | ||
| 16 | - | ||
| 17 | 9 | jakub | |
| 18 | 10 | X keyTyped() not firing with P2D and P3D | |
| 19 | 11 | X https://github.com/processing/processing/issues/3582 | |
@@ -31,6 +23,19 @@ X added note about AIOOBE seen earlier | |||
| 31 | 23 | X Update LowLevelGL to use VBOs | |
| 32 | 24 | X https://github.com/processing/processing-docs/pull/289 | |
| 33 | 25 | ||
| 26 | + cleaning | ||
| 27 | + X How do images behave when pixelDensity(2) is set? | ||
| 28 | + X https://github.com/processing/processing/issues/3364 | ||
| 29 | + X retina sketches slow to start | ||
| 30 | + X https://github.com/processing/processing/issues/2357 | ||
| 31 | + X zero alpha values still a problem with retina renderer | ||
| 32 | + X https://github.com/processing/processing/issues/2030 | ||
| 33 | + X fullScreen(SPAN) reported not working (cannot reproduce) | ||
| 34 | + X probably need to re-query for displays each time opening prefs | ||
| 35 | + X what happens when a screen is added after p5 has started? | ||
| 36 | + X https://github.com/processing/processing/issues/3381 | ||
| 37 | + X fixed in beta 1 | ||
| 38 | + | ||
| 34 | 39 | ||
| 35 | 40 | known issues | |
| 36 | 41 | _ P2D and P3D windows behave strangely when larger than the screen size | |
@@ -128,10 +133,6 @@ _ https://bugs.openjdk.java.net/browse/JDK-8027391 | |||
| 128 | 133 | _ test with JG's 13" retina laptop | |
| 129 | 134 | _ Ubuntu Unity prevents full screen from working properly | |
| 130 | 135 | _ https://github.com/processing/processing/issues/3158 | |
| 131 | - _ fullScreen(SPAN) reported not working (cannot reproduce) | ||
| 132 | - X probably need to re-query for displays each time opening prefs | ||
| 133 | - X what happens when a screen is added after p5 has started? | ||
| 134 | - _ https://github.com/processing/processing/issues/3381 | ||
| 135 | 136 | ||
| 136 | 137 | ||
| 137 | 138 | graphics | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -158,17 +158,13 @@ protected void done() { | |||
| 158 | 158 | ||
| 159 | 159 | ||
| 160 | 160 | /** Find out which error/warning the user has clicked and scroll to it */ | |
| 161 | - void scrollToMarkerAt(final int y) { | ||
| 161 | + private void scrollToMarkerAt(final int y) { | ||
| 162 | 162 | try { | |
| 163 | - new SwingWorker<Object, Object>() { | ||
| 163 | + new SwingWorker() { | ||
| 164 | 164 | protected Object doInBackground() throws Exception { | |
| 165 | - for (LineMarker m : errorPoints) { | ||
| 166 | - // -2 and +2 are extra allowance, clicks in the | ||
| 167 | - // vicinity of the markers register that way | ||
| 168 | - if (Math.abs(y - m.getY()) < 3) { | ||
| 169 | - editor.getErrorChecker().scrollToErrorLine(m.getProblem()); | ||
| 170 | - return null; | ||
| 171 | - } | ||
| 165 | + LineMarker m = findClosestMarker(y); | ||
| 166 | + if (m != null) { | ||
| 167 | + editor.getErrorChecker().scrollToErrorLine(m.getProblem()); | ||
| 172 | 168 | } | |
| 173 | 169 | return null; | |
| 174 | 170 | } | |
@@ -180,20 +176,18 @@ protected Object doInBackground() throws Exception { | |||
| 180 | 176 | ||
| 181 | 177 | ||
| 182 | 178 | /** Show tooltip on hover. */ | |
| 183 | - void showMarkerHover(final int y) { | ||
| 179 | + private void showMarkerHover(final int y) { | ||
| 184 | 180 | try { | |
| 185 | - new SwingWorker<Object, Object>() { | ||
| 181 | + new SwingWorker() { | ||
| 186 | 182 | protected Object doInBackground() throws Exception { | |
| 187 | - for (LineMarker m : errorPoints) { | ||
| 188 | - if (Math.abs(y - m.getY()) < 3) { | ||
| 189 | - Problem p = m.getProblem(); | ||
| 190 | - String kind = p.isError() ? | ||
| 191 | - Language.text("editor.status.error") : | ||
| 192 | - Language.text("editor.status.warning"); | ||
| 193 | - setToolTipText(kind + ": " + p.getMessage()); | ||
| 194 | - setCursor(Cursor.getPredefinedCursor(Cursor.HAND_CURSOR)); | ||
| 195 | - break; | ||
| 196 | - } | ||
| 183 | + LineMarker m = findClosestMarker(y); | ||
| 184 | + if (m != null) { | ||
| 185 | + Problem p = m.getProblem(); | ||
| 186 | + String kind = p.isError() ? | ||
| 187 | + Language.text("editor.status.error") : | ||
| 188 | + Language.text("editor.status.warning"); | ||
| 189 | + setToolTipText(kind + ": " + p.getMessage()); | ||
| 190 | + setCursor(Cursor.getPredefinedCursor(Cursor.HAND_CURSOR)); | ||
| 197 | 191 | } | |
| 198 | 192 | return null; | |
| 199 | 193 | } | |
@@ -204,6 +198,20 @@ protected Object doInBackground() throws Exception { | |||
| 204 | 198 | } | |
| 205 | 199 | ||
| 206 | 200 | ||
| 201 | + private LineMarker findClosestMarker(final int y) { | ||
| 202 | + LineMarker closest = null; | ||
| 203 | + int closestDist = Integer.MAX_VALUE; | ||
| 204 | + for (LineMarker m : errorPoints) { | ||
| 205 | + int dist = Math.abs(y - m.getY()); | ||
| 206 | + if (dist < 3 && dist < closestDist) { | ||
| 207 | + closest = m; | ||
| 208 | + closestDist = dist; | ||
| 209 | + } | ||
| 210 | + } | ||
| 211 | + return closest; | ||
| 212 | + } | ||
| 213 | + | ||
| 214 | + | ||
| 207 | 215 | public Dimension getPreferredSize() { | |
| 208 | 216 | return new Dimension(WIDE, super.getPreferredSize().height); | |
| 209 | 217 | } | |
| Back | FazBrowse Home | New Git URL |
0 commit comments